-
Notifications
You must be signed in to change notification settings - Fork 540
[chore] Clean up and unify (most) git-based routes #4470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jp-agenta
wants to merge
10
commits into
feat/unified-eval-loops
Choose a base branch
from
refactor/unify-revision-request-fields
base: feat/unified-eval-loops
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a087aa2
refactor(api): unify revision request body field names
jp-agenta 35bf4f6
Merge branch 'feat/add-retrieval-info-to-api-and-sdk' into refactor/u…
junaway b70ec74
Merge branch 'feat/add-retrieval-info-to-api-and-sdk' into refactor/u…
junaway de5ba57
Merge branch 'feat/add-retrieval-info-to-api-and-sdk' into refactor/u…
junaway be5329c
Merge branch 'release/v0.100.8' into refactor/unify-revision-request-…
junaway 4404cd8
more deep clean
jp-agenta c7edefd
fix tests
jp-agenta 88d4f07
Merge branch 'feat/unified-eval-loops' into refactor/unify-revision-r…
junaway 5860c46
Merge branch 'feat/unified-eval-loops' into refactor/unify-revision-r…
junaway 44dba70
fix CR
jp-agenta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return
400for conflicting source-variant IDs.Line 1072 turns contradictory inputs into
200 {count: 0}. That makes a malformed request look like an empty result set instead of a client error.Suggested fix
if application_variant_id: if ( application_variant_ref.id and application_variant_ref.id != application_variant_id ): - return ApplicationVariantResponse() + raise HTTPException( + status_code=status.HTTP_400_BAD_REQUEST, + detail="application_variant_id does not match application_variant_ref.id.", + ) if not application_variant_ref.id: application_variant_ref = Reference(id=application_variant_id)📝 Committable suggestion