fix: guard __dict__ access with is not None checks for optional tool fields#1408
Open
PHclaw wants to merge 1 commit into
Open
fix: guard __dict__ access with is not None checks for optional tool fields#1408PHclaw wants to merge 1 commit into
PHclaw wants to merge 1 commit into
Conversation
…fields hasattr() returns True even when the optional field value is None, causing AttributeError: 'NoneType' object has no attribute '__dict__' when OpenAI Agents SDK WebSearchTool/FileSearchTool have optional fields (user_location, filters, ranking_options) set to None. Fixes AgentOps-AI#1285
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasattr()returnsTrueeven when an optional field value isNone, causingAttributeError: 'NoneType' object has no attribute '__dict__'when OpenAI Agents SDKWebSearchTool/FileSearchToolhave optional fields (user_location,filters,ranking_options) set toNone.Changes
In
agentops/instrumentation/providers/openai/attributes/response.py, addedis not Noneguards alongside existinghasattr()checks in three places:get_response_tool_web_search_attributes:tool.user_location.__dict__get_response_tool_file_search_attributes:tool.filters.__dict__get_response_tool_file_search_attributes:tool.ranking_options.__dict__Fixes
Fixes #1285
Testing
Verified the fix with the reproduction case from #1285 — OpenAI Agents SDK
WebSearchTool/FileSearchToolwithNone-valued optional fields no longer crashon_span_end.