fix: add None checks to prevent __dict__ crash on optional tool attributes#1288
Open
MaxwellCalkin wants to merge 1 commit intoAgentOps-AI:mainfrom
Open
fix: add None checks to prevent __dict__ crash on optional tool attributes#1288MaxwellCalkin wants to merge 1 commit intoAgentOps-AI:mainfrom
MaxwellCalkin wants to merge 1 commit intoAgentOps-AI:mainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
AttributeError: 'NoneType' object has no attribute '__dict__'crash in tool attribute extraction.Fixes #1285.
Problem
Three
hasattr()checks in the tool attribute extraction guard calls to.__dict__on optional fields. Buthasattr()returnsTrueeven when the attribute value isNone, causing a crash:Affected fields:
WebSearchTool.user_location(line 507)FileSearchTool.filters(line 525)FileSearchTool.ranking_options(line 531)Fix
Add
is not Nonechecks alongside the existinghasattr()guards:Same pattern applied to all three affected fields.