fix(core): filter tool calls by origin for turn-based assertions#3
Merged
fix(core): filter tool calls by origin for turn-based assertions#3
Conversation
Tool call assertions now only count tool calls from the current turn, not from the entire conversation history. This fixes false test failures in multi-turn scenarios where previous turn tool calls were being counted. - Filter out tool calls with origin: 'history' - Include tool calls with origin: 'current' or undefined (backward compat) - Add comprehensive tests for origin filtering Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
origin: 'history'from the usage eventsorigin: 'current'orundefined(for backward compatibility)Problem
When running multi-turn conversation tests, tool call assertions counted tool calls from all turns in the conversation history, not just the current turn. This caused false test failures:
Solution
The API returns usage events with an
originfield:origin: "history"- Tool calls from previous turnsorigin: "current"- Tool calls made in the current turnAdded filtering in
http-agent.tsto only include current-turn tool calls.Test plan
origin: 'history'origin: 'current'🤖 Generated with Claude Code