Skip to content

chore: 155 - Include modelid or expertid#263

Merged
Exohayvan merged 1 commit into
mainfrom
ai/roadmap-step-1-155-20260721-131848
Jul 21, 2026
Merged

chore: 155 - Include modelid or expertid#263
Exohayvan merged 1 commit into
mainfrom
ai/roadmap-step-1-155-20260721-131848

Conversation

@Exohayvan

Copy link
Copy Markdown
Contributor

Roadmap step

phase-1/step-155: Step 155 - Include modelid or expertid

Objective

Complete the selected roadmap step using only the programmatically selected step details.

Selected step

# Step 155 - Include modelid or expertid

## Source Checklist Item
- [ ] Include `model_id` or `expert_id`.

## Goal
Ensure every initial model or expert manifest has a stable local identifier so validation receipts, lineage records, contribution attribution, and creator node references can point to the exact runnable model/expert being used. This step only defines the required identity field for the local prototype manifest and does not introduce networking, rewards, dashboards, or later-phase registry behavior.

## Implementation Checklist
- [ ] Add a required `model_id` or `expert_id` field to the initial manifest schema.
- [ ] Require at least one identifier to be present before the manifest is accepted.
- [ ] Keep the identifier stable across local validation runs unless the underlying model/expert meaningfully changes.
- [ ] Use a clear local naming convention that can be referenced by validation receipts, lineage entries, creator node ID records, and contribution attribution.
- [ ] Reject manifests where both identifiers are missing, blank, or only whitespace.
- [ ] Avoid implying global uniqueness, production registry status, decentralization, or token/reward eligibility.

## Required Tests Or Verification
- [ ] Validate a manifest containing `model_id` only.
- [ ] Validate a manifest containing `expert_id` only.
- [ ] Validate a manifest containing both fields, if the schema permits both.
- [ ] Confirm a manifest with neither field fails validation.
- [ ] Confirm validation output identifies the missing required identifier clearly.
- [ ] Confirm receipts or logs preserve the accepted identifier without rewriting it.

## Risks
- [ ] Ambiguous identifiers could break lineage and attribution.
- [ ] Treating local IDs as global IDs could create fake decentralization assumptions.
- [ ] Renaming IDs after validation could disconnect manifests from receipts.

## Done When
- [ ] Initial manifests cannot pass validation unless `model_id` or `expert_id` is present.
- [ ] Accepted identifiers are visible in validation output or receipts.
- [ ] The identifier can be used to trace local work back to the manifest, creator node ID, lineage, and contribution attribution.

Changes

e0451ac chore: complete phase-1 step-155
 docs/expert-manifest-v0.md             |   6 +-
 src/aethermesh_core/expert_manifest.py |  46 ++++++++++----
 tests/test_expert_manifest.py          |   8 ++-
 tests/test_expert_manifest_identity.py | 112 +++++++++++++++++++++++++++++++++
 4 files changed, 157 insertions(+), 15 deletions(-)

Validation

  • PYTHONDONTWRITEBYTECODE=1 python3 scripts/full_test.py --mode fast --base origin/main --keep-going

Safety notes

  • Roadmap selection was performed by the Python loop, not by the AI agent.
  • No force push used.
  • No hard reset used.
  • Local automation paths are intentionally omitted.

@Exohayvan Exohayvan added area:model-manifest Area: generated triage label for model manifest. priority:P3 Priority P3: normal planned work. risk:medium Risk: changes existing working behavior with moderate regression risk. system:runtime System: local node runtime/service lifecycle. type:maintenance Type: maintenance, cleanup, refactor, or dependency work. labels Jul 21, 2026
@Exohayvan
Exohayvan merged commit c992267 into main Jul 21, 2026
23 checks passed
@Exohayvan
Exohayvan deleted the ai/roadmap-step-1-155-20260721-131848 branch July 21, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:model-manifest Area: generated triage label for model manifest. priority:P3 Priority P3: normal planned work. risk:medium Risk: changes existing working behavior with moderate regression risk. system:runtime System: local node runtime/service lifecycle. type:maintenance Type: maintenance, cleanup, refactor, or dependency work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant