Skip to content

[recurring] Code generation: update services and models#1724

Open
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/recurring
Open

[recurring] Code generation: update services and models#1724
AdyenAutomationBot wants to merge 1 commit intomainfrom
sdk-automation/recurring

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the recurring service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers an automated update to the recurring service, primarily modifying the base URL used by the RecurringApi class. This change ensures the service points to the correct endpoint, reflecting recent updates in the underlying OpenAPI specification.

Highlights

  • Base URL Update: The base URL for the RecurringApi service has been updated from https://pal-test.adyen.com/pal/servlet/Recurring/v68 to https://paltokenization-test.adyen.com/pal/servlet/Recurring/v68.
  • Automated Code Generation: This pull request contains automated changes generated from an OpenAPI specification, specifically for the recurring service.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/main/java/com/adyen/service/recurring/RecurringApi.java
    • Updated the base URL for the RecurringApi constructor.
Activity
  • This pull request was automatically generated by AdyenAutomationBot.
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the base URL for the recurring service. However, this change introduces a critical issue. The new URL format breaks the logic for constructing the LIVE environment URL in the Service.createBaseURL method, which can lead to failed requests in production. The logic in Service.java needs to be updated to accommodate this new URL structure.

Comment on lines +47 to +48
this.baseURL =
createBaseURL("https://paltokenization-test.adyen.com/pal/servlet/Recurring/v68");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The new base URL https://paltokenization-test.adyen.com/... no longer contains pal-. This will cause an issue in the Service.createBaseURL method when constructing the URL for the LIVE environment.

The logic in Service.java (line 96) specifically checks for url.contains("pal-") to construct the live URL using the liveEndpointUrlPrefix. With this change, this condition will be false for the recurring service.

Consequently, the code will fall through to url.replaceFirst("-test", "-live") (line 130), resulting in a live URL of https://paltokenization-live.adyen.com/.... This is likely incorrect as it bypasses the required liveEndpointUrlPrefix for PAL services.

This will likely break existing integrations in the LIVE environment. The logic in Service.createBaseURL needs to be updated to handle this new URL structure, probably by also updating the string replacement logic to handle paltokenization-test.adyen.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant