Skip to content

chore: Refactor Gobo script; add config#1186

Draft
EttyKitty wants to merge 1 commit into
mainfrom
style-stuff
Draft

chore: Refactor Gobo script; add config#1186
EttyKitty wants to merge 1 commit into
mainfrom
style-stuff

Conversation

@EttyKitty

@EttyKitty EttyKitty commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Summary by cubic

Add .goborc.json with formatting rules and refactor the Windows formatter script to auto-download gobo.exe, run once over the project, and show a clear results summary. Remove the legacy run_gobo.bat.

  • Refactors
    • Added .goborc.json (4-space indent; vertical arrays/structs; no multiline ternary; explicitUndefined: false).
    • Reworked run_gobo.ps1: single project run, parses [Warn]/[Error], reports files processed and elapsed time, colorized output, sets exit codes, and downloads latest release if missing.
    • Removed run_gobo.bat.

Written for commit 211d3eb. Summary will update on new commits.

Review in cubic

@github-actions github-actions Bot added Area: JSON Changes to external JSON files or their under-the-hood functionality Size: Warning Type: Code Style Not affecting how code works, only visual changes labels May 22, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 413 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Note: This PR contains a large number of files. cubic only reviews up to 100 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.
Shadow auto-approve: would auto-approve. All changes are either formatting (blank lines, commas, spacing) enforced by the new gobo config, or the addition of explicit undefined for omitted optional arguments, which is semantically equivalent and safe.

Re-trigger cubic

@EttyKitty EttyKitty marked this pull request as draft May 22, 2026 10:47
@github-actions

Copy link
Copy Markdown
Contributor

This PR is marked as stale, because it has been open for 7 days with no activity.

@github-actions github-actions Bot added the Status: Stale No activity for more than a week label May 29, 2026
@github-actions github-actions Bot added Type: Docs Changes to documentation files Size: Medium and removed Size: Warning labels Jun 17, 2026
@EttyKitty EttyKitty changed the title style: Apply new gobo rules chore: Refactor Gobo script; add config Jun 17, 2026
@github-actions github-actions Bot added the Type: Chore Does something that does't fit other labels label Jun 17, 2026
@github-actions github-actions Bot added Size: Small and removed Type: Docs Changes to documentation files Size: Medium Status: Stale No activity for more than a week labels Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: JSON Changes to external JSON files or their under-the-hood functionality Size: Small Type: Chore Does something that does't fit other labels Type: Code Style Not affecting how code works, only visual changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant