Open
Conversation
c064528 to
92d3fed
Compare
Member
Author
|
I've had success with these changes in a downstream app. In a production build running: The timing was ~750ms. After these changes it was ~100ms faster. This is not a very scientific number :-p The idea is that most of the time spent during render is not in the rendering engine, but instead setup/teardown of dependencies. By creating less CPs we can minimize the necessary book-keeping. A bunch of work moves into the template layer, but that is already faster in old versions of Ember and improves throughout Ember's releases. |
92d3fed to
f9b8ab7
Compare
f9b8ab7 to
2e74c4f
Compare
2e74c4f to
2132302
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

For ember-tr and ember-td minimize CPs. This minimizes the watchers that need to be maintained.