Conversation
Member
Author
|
[ @yeshaokai I am going to merge this for time reasons, but if you can check the notebooks locally and make another PR for any changes you need, please do! ] |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a Jupyter Book configuration for demo notebooks and updates the demo notebooks to include improved headers, installation commands for amadeusgpt (and related dependencies), and adjustments to the API calls for SuperAnimal. Key changes include:
- Enhancements to notebook presentation and instructions, including API key handling.
- Updates to configuration files (_toc.yml, _config.yml) and a new GitHub Actions workflow for building and publishing the book.
- Improvements and patches in the amadeusgpt codebase related to keypoint file naming and PyTorch weights handling.
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| notebooks/YourData.ipynb | Updated header, installation steps, and API key setup; adds a placeholder code cell. |
| notebooks/Use_Task_Program.ipynb | Refined notebook text and code for task configuration and API key verification. |
| notebooks/MausHaus_demo.ipynb | Enhanced documentation and file path comments for demo video uploads. |
| notebooks/MABe_demo.ipynb | Similar improvements to demo instructions and API key handling. |
| notebooks/Horse_demo.ipynb | Added notebook header, file upload instructions, and configuration comments. |
| notebooks/EPM_demo.ipynb | Extended demo setup with file upload and detailed configuration comments. |
| amadeusgpt/utils/init.py | Introduced utility functions and a patch function for PyTorch weights handling. |
| amadeusgpt/managers/animal_manager.py | Added new attributes and refined keypoint file naming with additional error checks. |
| amadeusgpt/analysis_objects/model.py | Integrated the PyTorch patch into the SuperAnimal inference routine. |
| _toc.yml, _config.yml, .github/workflows/publish-book.yml | New Jupyter Book configuration and publishing workflow files. |
Comments suppressed due to low confidence (1)
amadeusgpt/utils/init.py:13
- [nitpick] Consider adding a docstring to the 'filter_kwargs_for_function' function to clarify its purpose and improve code documentation.
def filter_kwargs_for_function(func, kwargs):
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amadeusgptand uploading data