Skip to content

feat: remove kly#859

Merged
dev-adamant-im merged 17 commits intodevfrom
feat/remove-kly
Feb 23, 2026
Merged

feat: remove kly#859
dev-adamant-im merged 17 commits intodevfrom
feat/remove-kly

Conversation

@S-FrontendDev
Copy link
Copy Markdown
Member

@S-FrontendDev S-FrontendDev commented Sep 3, 2025

Description

  • Removed support for KLY (Klayr) from the codebase.
  • Updated the wallets script.
  • Replaced lodash dependency with lodash-es.
  • Cleaned up related modules, actions, and imports (kly-base, kly-base-actions.js, etc.).
  • Resolved merge conflicts in scripts/wallets.mjs and related files.

Related issue

Closes #

Breaking changes

  • Yes — removal of KLY is a breaking change.
  • Users who previously relied on KLY wallets or transactions will no longer have access to this functionality.

How to test

  1. Build and run the app, ensure there are no missing imports or errors related to KLY.
  2. Verify wallet functionality (creation, balance, transactions) for other currencies (e.g., ADM) works as expected.
  3. Run the wallets script to confirm correct behavior without KLY.
  4. Confirm that the switch from lodash to lodash-es does not break existing functionality.
  5. Check that no UI elements or references to KLY remain in the app.

Notes for reviewers

  • Double-check for leftover KLY dependencies or unused imports.
  • Ensure that removed code did not affect unrelated modules.
  • Pay attention to tests — confirm that they were updated/removed where KLY was involved.
  • Review bundle size and tree-shaking impact from migrating to lodash-es.
  • Consider the impact on user data if any KLY wallets existed previously.

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
adamant-im Ready Ready Preview, Comment Feb 23, 2026 3:35pm

@S-FrontendDev S-FrontendDev marked this pull request as ready for review September 22, 2025 12:12
@S-FrontendDev S-FrontendDev requested a review from a team as a code owner September 22, 2025 12:12
# Conflicts:
#	scripts/wallets.mjs
#	src/store/modules/kly-base/kly-base-actions.js
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 22, 2025

Deployed to https://msg-adamant-pr-859.surge.sh 🚀

@S-FrontendDev S-FrontendDev linked an issue Sep 22, 2025 that may be closed by this pull request
6 tasks
@S-FrontendDev S-FrontendDev requested review from a team and graycraft September 23, 2025 15:57
@dev-adamant-im dev-adamant-im added APIs API design, endpoints, and integrations Blockchain Related to blockchain functionality, consensus, and ledger mechanics Composite task Large or complex task that consists of multiple subtask JavaScript Frontend or backend code in JavaScript labels Oct 7, 2025
@dev-adamant-im dev-adamant-im added this to the v4.11.0 milestone Oct 7, 2025
@dev-adamant-im dev-adamant-im removed this from the v4.11.0 milestone Oct 7, 2025
Copy link
Copy Markdown
Member

@dev-adamant-im dev-adamant-im left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@S-FrontendDev

Enter a new account.
Check dev console, probably ReferenceError: Cannot access 'B' before initialization caused by these changes.

image

@S-FrontendDev
Copy link
Copy Markdown
Member Author

@dev-adamant-im i can't repeat it. Where did you get it? What staging?

@dev-adamant-im
Copy link
Copy Markdown
Member

dev-adamant-im commented Oct 7, 2025

@S-FrontendDev

Log in test account, wait for chats, then log out.
https://msg-adamant-pr-859.surge.sh/

Production https://adm.im doesn't have these errors.

image

# Conflicts:
#	src/components/SendFundsForm.vue
#	src/lib/nodes/kly-indexer/KlyIndexer.ts
#	src/lib/nodes/kly-indexer/KlyIndexerClient.ts
#	src/lib/nodes/kly-indexer/index.ts
#	src/lib/nodes/kly/KlyClient.ts
#	src/lib/nodes/kly/KlyNode.ts
#	src/lib/nodes/kly/index.ts
#	src/lib/sockets.js
#	src/store/modules/kly-base/kly-base-actions.js
#	src/store/modules/kly/kly-actions.js
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes KLY (Klayr) cryptocurrency support from the ADAMANT messenger application and migrates from lodash to lodash-es for better tree-shaking.

Changes:

  • Removed KLY blockchain integration including store modules, API clients, transaction components, and utilities
  • Replaced lodash with lodash-es for improved bundle optimization
  • Removed KLY-specific configuration, icons, and localization strings

Reviewed changes

Copilot reviewed 91 out of 92 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Removed @klayr/* dependencies, replaced lodash with lodash-es
src/lib/constants/index.ts Removed KLY-related constants and helper functions
src/lib/constants/cryptos/data.json Removed KLY cryptocurrency configuration and updated node endpoints
src/store/modules/kly/* Deleted KLY store module (state, actions, mutations, getters)
src/store/modules/kly-base/* Deleted KLY base store functionality
src/lib/klayr/* Deleted all Klayr utility functions, types, and account management
src/lib/nodes/kly/* Deleted KLY node client and API implementations
src/lib/nodes/kly-indexer/* Deleted KLY indexer service client
src/components/transactions/KlyTransaction.vue Deleted KLY transaction component
src/views/transactions/Transaction.vue Removed KLY transaction component reference
src/components/SendFundsForm.vue Removed KLY-specific text data field and validation
src/lib/validateAddress.ts Removed KLY address validation
src/lib/uri.js Removed Klayr wallet URI parsing
scripts/wallets.mjs Updated to use named imports from lodash-es
src/locales/*.json Removed KLY-specific error messages
src/config/*.json Removed KLY node and service configurations
Comments suppressed due to low confidence (6)

src/components/transactions/utils/getInconsistentStatus.spec.ts:1

  • Corrected spelling of 'WORNG_TX_HASH' to 'WRONG_TX_HASH'.
import { describe, test, expect } from 'vitest'

src/lib/txVerify.js:1

  • The comment 'Node returns errors array' is vague. Consider being more specific about which type of node returns this error format, such as 'Blockchain node returns errors array' or 'API returns errors in array format'.
    src/store/modules/partners/partner-actions.js:1
  • The removal of the onlyLegacyLiskAddress check suggests that parseCryptoAddressesKVStxs may now return different values. Ensure that the function cannot return an object with a falsy mainAddress when addresses is truthy, as this could lead to unexpected behavior.
    src/lib/store-crypto-address.js:1
  • The function signature changed from parseCryptoAddressesKVStxs(txs, crypto) to parseCryptoAddressesKVStxs(txs), removing the crypto parameter. However, there's a call to this function at line 76 that still passes the crypto parameter: parseCryptoAddressesKVStxs(txs, crypto). This inconsistency will cause the function to receive an extra argument that it no longer uses.
    src/lib/nodes/services.ts:1
  • The services object is missing consistent ordering. Consider alphabetically sorting the service entries for better maintainability.
    src/store/modules/services/types.ts:1
  • This formatting change from comma to semicolon separator is inconsistent with TypeScript conventions for type definitions. While both are valid, the original comma separator is more commonly used in TypeScript type definitions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/SendFundsForm.vue Outdated
Comment thread scripts/wallets.mjs Outdated
@dev-adamant-im
Copy link
Copy Markdown
Member

dev-adamant-im commented Feb 23, 2026

Summary:

  • Updated branch with latest dev and synced wallet configs from adamant-wallets
  • Removed KLY/Klayr support and legacy LSK leftovers from code, configs, and related modules
  • Restored transaction inconsistency tests (ETH), kept ADM self-transfer behavior

@dev-adamant-im dev-adamant-im merged commit 1d0bec1 into dev Feb 23, 2026
5 checks passed
@github-actions
Copy link
Copy Markdown

Successfully tore down https://msg-adamant-pr-859.surge.sh 🥲

@adamant-al adamant-al deleted the feat/remove-kly branch March 2, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APIs API design, endpoints, and integrations Blockchain Related to blockchain functionality, consensus, and ledger mechanics Composite task Large or complex task that consists of multiple subtask JavaScript Frontend or backend code in JavaScript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] Remove Klayr (KLY) support in full

4 participants