feat: remove kly#859
Conversation
Fix samsung height
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
# Conflicts: # scripts/wallets.mjs # src/store/modules/kly-base/kly-base-actions.js
|
Deployed to https://msg-adamant-pr-859.surge.sh 🚀 |
dev-adamant-im
left a comment
There was a problem hiding this comment.
|
@dev-adamant-im i can't repeat it. Where did you get it? What staging? |
|
Log in test account, wait for chats, then log out. Production https://adm.im doesn't have these errors.
|
# Conflicts: # src/components/SendFundsForm.vue # src/lib/nodes/kly-indexer/KlyIndexer.ts # src/lib/nodes/kly-indexer/KlyIndexerClient.ts # src/lib/nodes/kly-indexer/index.ts # src/lib/nodes/kly/KlyClient.ts # src/lib/nodes/kly/KlyNode.ts # src/lib/nodes/kly/index.ts # src/lib/sockets.js # src/store/modules/kly-base/kly-base-actions.js # src/store/modules/kly/kly-actions.js
There was a problem hiding this comment.
Pull request overview
This PR removes KLY (Klayr) cryptocurrency support from the ADAMANT messenger application and migrates from lodash to lodash-es for better tree-shaking.
Changes:
- Removed KLY blockchain integration including store modules, API clients, transaction components, and utilities
- Replaced
lodashwithlodash-esfor improved bundle optimization - Removed KLY-specific configuration, icons, and localization strings
Reviewed changes
Copilot reviewed 91 out of 92 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removed @klayr/* dependencies, replaced lodash with lodash-es |
| src/lib/constants/index.ts | Removed KLY-related constants and helper functions |
| src/lib/constants/cryptos/data.json | Removed KLY cryptocurrency configuration and updated node endpoints |
| src/store/modules/kly/* | Deleted KLY store module (state, actions, mutations, getters) |
| src/store/modules/kly-base/* | Deleted KLY base store functionality |
| src/lib/klayr/* | Deleted all Klayr utility functions, types, and account management |
| src/lib/nodes/kly/* | Deleted KLY node client and API implementations |
| src/lib/nodes/kly-indexer/* | Deleted KLY indexer service client |
| src/components/transactions/KlyTransaction.vue | Deleted KLY transaction component |
| src/views/transactions/Transaction.vue | Removed KLY transaction component reference |
| src/components/SendFundsForm.vue | Removed KLY-specific text data field and validation |
| src/lib/validateAddress.ts | Removed KLY address validation |
| src/lib/uri.js | Removed Klayr wallet URI parsing |
| scripts/wallets.mjs | Updated to use named imports from lodash-es |
| src/locales/*.json | Removed KLY-specific error messages |
| src/config/*.json | Removed KLY node and service configurations |
Comments suppressed due to low confidence (6)
src/components/transactions/utils/getInconsistentStatus.spec.ts:1
- Corrected spelling of 'WORNG_TX_HASH' to 'WRONG_TX_HASH'.
import { describe, test, expect } from 'vitest'
src/lib/txVerify.js:1
- The comment 'Node returns errors array' is vague. Consider being more specific about which type of node returns this error format, such as 'Blockchain node returns errors array' or 'API returns errors in array format'.
src/store/modules/partners/partner-actions.js:1 - The removal of the
onlyLegacyLiskAddresscheck suggests thatparseCryptoAddressesKVStxsmay now return different values. Ensure that the function cannot return an object with a falsymainAddresswhenaddressesis truthy, as this could lead to unexpected behavior.
src/lib/store-crypto-address.js:1 - The function signature changed from
parseCryptoAddressesKVStxs(txs, crypto)toparseCryptoAddressesKVStxs(txs), removing thecryptoparameter. However, there's a call to this function at line 76 that still passes thecryptoparameter:parseCryptoAddressesKVStxs(txs, crypto). This inconsistency will cause the function to receive an extra argument that it no longer uses.
src/lib/nodes/services.ts:1 - The services object is missing consistent ordering. Consider alphabetically sorting the service entries for better maintainability.
src/store/modules/services/types.ts:1 - This formatting change from comma to semicolon separator is inconsistent with TypeScript conventions for type definitions. While both are valid, the original comma separator is more commonly used in TypeScript type definitions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Summary:
|
|
Successfully tore down https://msg-adamant-pr-859.surge.sh 🥲 |


Description
walletsscript.lodashdependency withlodash-es.kly-base,kly-base-actions.js, etc.).scripts/wallets.mjsand related files.Related issue
Closes #
Breaking changes
How to test
walletsscript to confirm correct behavior without KLY.lodashtolodash-esdoes not break existing functionality.Notes for reviewers
lodash-es.