Check the copied project logos against their sources - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AER and Folio to the Start here table, using each project's own mark. Folio uses its small variant, which drops the body line so the F arms still read at 20px.
The six icons are copies of assets owned by other projects, so a redraw upstream would leave a stale mark on the profile with nothing to catch it. A weekly workflow now fetches each source and compares. Five are watched: four byte-for-byte, and vega on its star path, since the public vega-agent repo ships only the large gradient logo rather than the favicon the copy came from. Folio has no public repo or site, so it is declared unchecked in the manifest with a reason instead of being left out. An icon with no manifest entry fails the check, as does an entry with no file.
A scheduled failure opens an issue rather than just going red, since nobody watches a cron run, and closes it once the copies match again.