Skip to content

ENG-1924: Promote staging files without adding a release/ prefix #3851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchell-as merged 1 commit into from
Jul 21, 2026
Merged

ENG-1924: Promote staging files without adding a release/ prefix #3851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions scripts/ci/s3-promoter/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ func run() {
// Copy each staging object to production location and delete the staging version
for _, obj := range stagingObjects {
stagingKey := *obj.Key
relativeKey := strings.TrimPrefix(stagingKey, basePrefix+"staging/")
destinationKey := basePrefix + "release/" + relativeKey
destinationKey := productionKey(stagingKey, basePrefix)

fmt.Printf("Promoting %s -> %s\n", stagingKey, destinationKey)

Expand All @@ -94,6 +93,14 @@ func run() {
fmt.Printf("Successfully promoted %d files from staging to production.\n", len(stagingObjects))
}

// productionKey maps a staging object key to its production location. The
// channel (beta, release, ...) is already encoded in the key, so promotion only
// drops the staging/ segment and adds no prefix of its own.
func productionKey(stagingKey, basePrefix string) string {
relativeKey := strings.TrimPrefix(stagingKey, basePrefix+"staging/")
return basePrefix + relativeKey
}

func createClient() {
var err error

Expand Down
Loading