feat(consumer): Expose local_id accessor on NodeId#690
Draft
SuchAFuriousDeath wants to merge 1 commit intoAccessKit:mainfrom
Draft
feat(consumer): Expose local_id accessor on NodeId#690SuchAFuriousDeath wants to merge 1 commit intoAccessKit:mainfrom
local_id accessor on NodeId#690SuchAFuriousDeath wants to merge 1 commit intoAccessKit:mainfrom
Conversation
1 task
Member
|
The fact that you cannot get the local ID out of a consumer node ID is on purpose and I would really like to keep it that way. Have you tried refactoring the egui accessibility inspector using |
Contributor
Author
|
I see. Thanks, I'll see if that works for egui. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out one more change is required for emilk/egui#7853 😅