feature/2422 implement onlyPublished optional param to filter retrieved journeys#2445
Conversation
Coverage ReportCommit:4f95da3Base: develop@c314d04
Details (changed files):
|
Suggested documentation updatesCommand: ... retrieve only published version of journeys with --onlyPublished option: This optional parameter can be used with the retrieve command when retrieving journeys. When specified, only published versions of journeys are retrieved. If a journey does not have a published version, no version of that journey is retrieved. Examples: mcdev retrieve MyProject/DEV journey --onlyPublished mcdev r cred/bu -m journey:name:myName --onlyPublished mcdev r cred/bu journey "key" --onlyPublished |
# Conflicts: # @types/lib/metadataTypes/Journey.d.ts.map
|
somehow this didnt work. had a look into fixing this but couldnt find a quick one´. do you wanna push it forward or shall I? |
|
ok, now i see the difference: when i tried this, i did so by trying to retrieve a single journey, specified by name and key respectively. your test did a retrieve without name or key. |
|
@JoernBerkefeld I couldn't get the API endpoint to work when the key or the id has been specified. It just ignores the query param and retrieves the latest version. So for single key/id retrieve if the onlyPublished param is enabled, retrieve retrieves all published journeys and then finds the one the user asked for and retrieves that journey version with activities. mcdev r cred/bu -m journey:name:myName --onlyPublished |
JoernBerkefeld
left a comment
There was a problem hiding this comment.
few minor changes - i took the liberty of providing commit-ready options for you.
fyi: i removed the inline /** @type {object} */ because it wasnt flagged on my computer as missing when i tried removing it locally - and it didnt add much value.
Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
|
Thank you for your good work & effort @yuliialikhyt ❤️ |

PR details
What changes did you make? (Give an overview)
Added a new optional parameter for the retrieve function. If --onlyPublished is true, the published version of the journeys is retrieved.
Further details (optional)
...
Checklist