Skip to content

Fixing flaky test#256

Open
crawlingcub wants to merge 1 commit intoAccenture:mainfrom
crawlingcub:patch-1
Open

Fixing flaky test#256
crawlingcub wants to merge 1 commit intoAccenture:mainfrom
crawlingcub:patch-1

Conversation

@crawlingcub
Copy link

I ran your test-suite by removing all seed settings (such as np.random_seed(0)) and found that some tests fail quite often. For instance, the test test_select_best_model_ranking_random failed 3 out of 500 times. Each time the same assertion failed.

To fix the test, I modified the assertion to ensure that it does not fail if the seeds are removed (or if the seed/rng implementation is changed in the future). The test does not fail now at all without seeds.

Please let me know if this fix seems reasonable. If yes, I can also look into other tests which failed and try to make them less flaky. I will be happy to incorporate any other changes that you guys may suggest.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant