Force change permissions before deleting directory#1940
Open
SitiSchu wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
Force change permissions before deleting directory#1940SitiSchu wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
SitiSchu wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1940 +/- ##
==========================================
- Coverage 60.01% 59.78% -0.24%
==========================================
Files 163 163
Lines 20098 20003 -95
Branches 3494 3492 -2
==========================================
- Hits 12062 11958 -104
- Misses 7224 7229 +5
- Partials 812 816 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SitiSchu
force-pushed
the
1493_win_pkg_cache_issue
branch
from
b04858c to
e318ce3
Compare
SitiSchu
force-pushed
the
1493_win_pkg_cache_issue
branch
from
3e0eb0a to
9ad741a
Compare
…wareFoundation#1493 Signed-off-by: SitiSchu <admin@sitischu.com>
SitiSchu
force-pushed
the
1493_win_pkg_cache_issue
branch
from
9ad741a to
cd23839
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1493
This will skip the permission checks before deleting a directory since they don't seem to work on Windows.
Also, if we're deleting a folder the permissions aren't really that important.