NanoVDB: run the builders on a synchronous memory resource (CUDA) - #2272
Draft
harrism wants to merge 37 commits into
Draft
NanoVDB: run the builders on a synchronous memory resource (CUDA)#2272harrism wants to merge 37 commits into
harrism wants to merge 37 commits into
Conversation
Name the free operation destroy, as cuda::buffer does, and add the stream-taking overload it also provides. clear stays but only as a transitional delegate, marked as such: it exists because GridHandle::reset still calls it, and goes away with the legacy dual buffers that cuda::Buffer replaces. Rename setStream to set_stream. Member names cannot be aliased, so matching the standard spelling is the whole reason the resource concept kept allocate_async; the same argument applies here. Note in passing that ours deliberately does not synchronize, matching cuda::buffer's set_stream_unsynchronized rather than its set_stream, whose own documentation and implementation disagree (NVIDIA/cccl#10649). Add swap. The generic std::swap already does the right thing through the move operations, but both std::vector and rmm::device_buffer provide one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
Eleven of the builder's buffers are device-only -- nothing reads them on the host -- yet they were cuda::DeviceBuffer, whose host pointer and per-device array they never use. Move them to the single-space cuda::Buffer and give the builder a resource parameter, so its scratch is injectable like PointsToGrid's already is, and freed by scope rather than by hand. mProcessedRoot and mData are read on the host and stay dual. This is not a speedup: DeviceBuffer::init allocates host or device memory but never both, and these buffers always passed a real device id, so no cudaMallocHost was on this path to begin with. Measured dilate on 1k/20k/ 200k points, and the difference is within run-to-run noise. Hoist the Data struct out of the class. It does not depend on the resource, and leaving it nested would give every ResourceT its own incompatible type for the device functors to name. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
A stream-ordered resource must also model the synchronous concept, which means writing four methods where two would do. The synchronous pair is not a bare delegate -- memory from allocate must be usable on any stream when it returns, so the null-stream allocation has to be synchronized first -- and omitting that yields memory which satisfies the concept but is not actually synchronous. Put it in one place rather than leaving each author to rediscover it. The two resources in TestMemoryResource are the first users, and were already wrong in exactly that way: they provide only the async pair, so they never modelled is_async_resource. TempPool duck-typed and never checked, so nothing caught it. MeshToGrid was the last builder allocating from a hard-wired DeviceResource, through TempDevicePool. Give it a ResourceT parameter and thread it into both its TopologyBuilder and its pool. As with Data in the builder, BoxTrianglePair is hoisted out of the class: it does not depend on the resource, and leaving it nested would give every ResourceT its own incompatible type for the device functors to name. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
…uffer Buffer holds its resource by value, matching cuda::buffer -- whose model this completes: in CCCL the ownership semantics are selected by what is placed in the by-value slot, an owning any_resource or a borrowing resource_ref. We adopted the slot without the borrowing type, so a container like TempPool, whose contract is a non-owning pointer to a possibly stateful resource, had no way to hold a Buffer without copying that resource and stranding its state. ResourceRef is the missing piece: a non-owning reference that is itself a resource, so copying the ref shares the underlying instance. Its async methods exist only when R models AsyncResource, so a ref over a synchronous resource does not misreport its tier, and two refs compare equal exactly when they reference the same resource. TempPool now keeps its bytes in a Buffer<std::byte, ResourceRef<R>>: same resource contract, same stream retention, same discard-on-growth reallocation, but the block is freed by ownership rather than by hand. The TempPool unit tests, which assert traffic against the caller's own resource instance, pass unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
The bisection search over voxel size was written as a backward goto, which made the lifetimes of the buffers it retries over non-lexical. Rewrite it as while(true) with continue on retry and break on convergence; the six hand-written frees before the jump are unchanged. The change is easiest to review with whitespace ignored, since the loop body re-indents: git diff -w shows 27 changed lines. d_keys and d_node_count carry results past the loop, so their declarations move above it, as does the copy event, which was created inside the retried region on every iteration but destroyed only once at the end -- each retry leaked the previous handle. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
Every device array PointsToGrid allocates is now owned by a Buffer<T, ResourceRef<ResourceT>> borrowing the injected resource -- members where the pipeline frees them in a later member function than the one that allocated them (countNodes allocates; processUpperNodes, processLeafNodes, processPoints and processBBox release), locals where the lifetime is contained. The raw pointers survive only as views: the device-visible fields inside mData, and the working pointers the cub and kernel calls take. Every owner event -- assignment, swap, destroy -- immediately refreshes its view, and released views are nulled so a stale use faults instead of reading a freed block. The index ping-pong becomes a swap of owners across the member/local boundary, replacing the bare pointer swap whose safety depended on nothing reading the device copy of d_indx between the two uploads. The density-search retry keeps its free-before-reallocate order via explicit destroy calls, so peak device memory is unchanged. The hand-matched byte sizes at every free site disappear, and the arrays released one line before scope exit now just leave scope. One behavior change worth naming: the too-many-points-per-leaf throw previously leaked the reduction scratch; ownership now releases it during unwind. Verified against the previous commit with a counting resource over three shapes (bulk segmented-sort branch, serial per-tile branch, and the bisection retry engaged): allocation count, free count, and total bytes are identical. Full CUDA and memory-resource suites unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
Each release site sits in a function that receives the stream, so pass it to destroy rather than relying on the retained stream matching -- they are the same on every current path, but the explicit form does not depend on that staying true. Also drop the cudaGetDevice calls whose result the Buffer conversion left unused. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Mark Harris <mharris@nvidia.com>
The scratch buffers held their resource by value, so each of the eight carried its own copy -- fine for the stateless default, wrong for a stateful resource, whose accounting would be split across copies while the caller's instance saw nothing. Borrow through ResourceRef instead, the same reconciliation TempPool uses. Assert the stream-ordered requirement directly in TopologyBuilder and MeshToGrid so a synchronous-only resource fails with a diagnostic that names the builder, not just the pool inside it. Note SyncFromAsync's synchronize cost on its allocate. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Mark Harris <mharris@nvidia.com>
The too-many-points-per-leaf throw unwinds past the event's manual destroy, leaking the handle. Own it with a small guard so unwinding releases it, consistent with the buffer ownership in this function. Also assert the stream-ordered resource requirement on the class, so a synchronous-only resource fails naming PointsToGrid rather than the pool inside it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
The builders require a stream-ordered resource, which a device without memory-pool support cannot provide through cudaMallocAsync. Two additions close the gap. MallocResource is a synchronous cudaMalloc/cudaFree resource that works on any device. AsyncFromSync presents a synchronous resource as a stream-ordered one -- the mirror of SyncFromAsync, and the analog of cuda::mr's synchronous_resource_adapter: allocate_async forwards, since synchronously allocated memory is already valid on every stream, and deallocate_async synchronizes the stream first, which makes the synchronous contract's quiescence requirement hold. The serialization cost of that synchronize is documented at the type, so a synchronous backend is an explicit caller choice rather than a silent substitution. The new test drives PointsToGrid end-to-end with an injected AsyncFromSync over a stateful synchronous resource: every scratch allocation routes through cudaMalloc and is freed through the caller's instance, never touching stream-ordered allocation -- which is exactly what a pool-less device requires of the scratch path. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
harrism
requested review from
Idclip,
apradhana,
danrbailey,
jmlait,
kmuseth and
richhones
as code owners
August 5, 2026 05:27
The byte scratch is reinterpreted as word-sized types, which is valid for every resource whose DEFAULT_ALIGNMENT is at least word alignment -- all CUDA allocation paths give 256 -- but nothing said so. Assert it, so a custom resource with a weaker guarantee fails at compile time instead of misaligning on the device. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Mark Harris <mharris@nvidia.com>
Legal without one -- the macro expands to a braced block -- but every other use in the file spells it as a statement. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
…-builders Signed-off-by: Mark Harris <mharris@nvidia.com>
5 tasks
Null-free is a no-op everywhere else, so there is no quiescence to establish and no reason to synchronize the stream for it. Also correct the sync-resource test's comment: the grid handle's output buffer is allocated through BufferT, not the injected resource, so "every builder allocation" overstated what the test demonstrates -- it is the scratch allocations that never touch stream-ordered allocation. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
Contributor
Author
|
Copilot cycles (fork mirror: harrism#4). Net changes (aac7f00): the sync-resource test's comment now says scratch allocations and names the grid handle's output buffer as the exception, and |
cuda::buffer's set_stream is deliberately non-synchronizing -- its documented synchronization is a stale note left behind when the synchronization was removed -- so our non-synchronizing set_stream matches it in both name and contract, and the comment claiming a divergence was wrong. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Mark Harris <mharris@nvidia.com>
…-builders Signed-off-by: Mark Harris <mharris@nvidia.com>
3 tasks
Documentation-level only: the [[deprecated]] attribute would warn from GridHandle::reset and NodeManager::reset, template members in our own headers that must keep calling clear() until every buffer type provides destroy() -- an unactionable diagnostic for callers of reset(), and a build break under -Werror. The attribute lands when those callers migrate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Mark Harris <mharris@nvidia.com>
…-builders Signed-off-by: Mark Harris <mharris@nvidia.com>
…trofit Signed-off-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Mark Harris <mharris@nvidia.com>
…-builders Signed-off-by: Mark Harris <mharris@nvidia.com>
harrism
marked this pull request as draft
August 8, 2026 00:59
The trait checks detect allocate/deallocate through unevaluated contexts, which never odr-use them, so nvcc warned that every synchronous pair and stub member was declared but never referenced (AcademySoftwareFoundation#177-D). The attribute route is closed -- nvcc's front end ignores [[maybe_unused]] for this diagnostic -- so reference them the honest way: a test that verifies the synchronous halves of the counting and stream-recording doubles behave like their stream-ordered halves, and one that pins the trait probes' stub behavior. The TU now builds with no warnings at all. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Mark Harris <mharris@nvidia.com>
…-builders Signed-off-by: Mark Harris <mharris@nvidia.com>
…buffer Signed-off-by: Mark Harris <mharris@nvidia.com> # Conflicts: # nanovdb/nanovdb/tools/cuda/TopologyBuilder.cuh # nanovdb/nanovdb/unittest/TestBuffer.cu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2231/#2251, part of #2232. This closes the scratch half of step 2's acceptance criterion: "NanoVDB builds and runs on a pool-less vGPU via an injected synchronous cudaMalloc-backed resource."
What
The builders require a stream-ordered resource, which a device without memory-pool support (
cudaDevAttrMemoryPoolsSupported == 0, e.g. AWSg6f, cf. #2255) cannot provide throughcudaMallocAsync— the wrappers fail loudly there by design (#2256). Two additions close the gap as pure library code:cuda::MallocResource— a synchronouscudaMalloc/cudaFreeresource that works on any device. Modelsis_resourceonly.cuda::AsyncFromSync<R>— presents a synchronous resource as a stream-ordered one; the mirror ofSyncFromAsync, and the analog ofcuda::mr'ssynchronous_resource_adapter.allocate_asyncforwards — synchronously allocated memory is already valid on every stream, a stronger guarantee than stream-ordering requires.deallocate_asyncsynchronizes the stream first, which makes the synchronous contract's quiescence requirement hold.So the pool-less path is
PointsToGrid<BuildT, AsyncFromSync<MallocResource>>(or anAsyncFromSync<ResourceRef<YourArena>>for a stateful arena), with no build flags.Why a wrapper rather than dispatch inside the builders
The roadmap's rule is that a synchronous arena is never a silent
allocate_asyncfacade — a facade misrepresents its semantics and hands multi-stream callers unexpected serialization.AsyncFromSyncis the explicit, honest version of the same lift: every deallocation synchronizes its stream, that cost is documented at the type, and the caller chooses it. This is also exactly the design CCCL settled on (synchronous_resource_adaptersynchronizes beforedeallocate_syncwhen wrapping a synchronous resource). The alternative —if constexprdispatch at every builder release site — spreads the same synchronization across ~30 sites instead of one audited method.What this does not close
The grid handle's buffer still goes through
GridHandle<BufferT>'s buffer type (defaultDeviceBuffer→cudaMallocAsync), so a fully flag-free pool-less deployment still needsNANOVDB_USE_SYNC_CUDA_MALLOCfor that one allocation until step 3 deliversGridHandle<cuda::Buffer<std::byte,R>>. Scratch — the overwhelming majority of allocations — is closed here.Testing
New
TestMemoryResource.PointsToGrid_RunsOnSynchronousResource: drivesPointsToGridend-to-end withAsyncFromSync<ResourceRef<SyncCountingResource>>— a stateful, synchronous-only resource. Asserts the grid builds, that scratch really routed through the synchronous resource (allocs > 0), and that every allocation was freed through the caller's instance (allocs == deallocs). On pooled hardware this path bypasses pools entirely, which is precisely what a pool-less device requires, so the dispatch is exercised without vGPU hardware; final validation on a realg6fwould be a good CI follow-up once #2264 lands. Plusstatic_asserts pinning the tiers (MallocResourceis sync-only; the wrapper models async).Suites: memory-resource 10/10,
TestBuffer27/27, full CUDA 52/53 (pre-existingUnifiedBuffer_IOdata-file failure). Per #2264, CI builds but does not run these — numbers are from a local RTX 6000 Ada, CUDA 12.6.