Clip Property kOfxImageClipPropDisplayTimeOffset

[fxtech]

Issue #58
I added a #define and description for kOfxImageClipPropDisplayTimeOffset.
A plugin can query this read-only clip property to determine the clip starting frame number in the environment's user time domain. ie if the clip starts at frame 1001, this property would return 1001. This value should be added to time values for purposes of display in a custom user interface that shows frame numbers (ie. a special preset browser or custom player).

[garyo]

Perhaps: "Plugins should add this value to internal OFX frame numbers when displayed in a plugin user interface, so the user will see the same frame numbers as they see in the host's UI."

[fxtech]

Yes. For example, if you have a Session in Silhouette that starts at frame 1001, and you launch the Mocha Pro OFX UI, it shows the frame range starting at 0. By adding this value, it can show the same frame numbers.

…

On Tue, Nov 12, 2019, 5:38 PM GaryO ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In include/ofxImageEffect.h <#67 (comment)>: > @@ -929,6 +929,16 @@ then the plugin can detect this via an identifier change and re-evaluate the cac */ #define kOfxImagePropUniqueIdentifier "OfxImagePropUniqueIdentifier" +/** @brief Clip property which indicates the display start frame of the clip + + - Type - double X 1 + - Property Set - clip instance (read only) + - Default - 0 + +This value should be added to the internal frame number when displayed in a plugin user interface ..., so that the user sees the same frame number as they see in the host UI. (?) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#67>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM64ASENPG7GUZ63QDYSZ3QTM5AZANCNFSM4JMILA4Q> . On Tue, Nov 12, 2019, 5:38 PM GaryO ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In include/ofxImageEffect.h <#67 (comment)>: > @@ -929,6 +929,16 @@ then the plugin can detect this via an identifier change and re-evaluate the cac */ #define kOfxImagePropUniqueIdentifier "OfxImagePropUniqueIdentifier" +/** @brief Clip property which indicates the display start frame of the clip + + - Type - double X 1 + - Property Set - clip instance (read only) + - Default - 0 + +This value should be added to the internal frame number when displayed in a plugin user interface ..., so that the user sees the same frame number as they see in the host UI. (?) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#67>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM64ASENPG7GUZ63QDYSZ3QTM5AZANCNFSM4JMILA4Q> .

[garyo]

Perfect. Can you update the PR?

…

--Gary

On Tue, Nov 12, 2019, 8:06 PM Paul Miller ***@***.***> wrote: Yes. For example, if you have a Session in Silhouette that starts at frame 1001, and you launch the Mocha Pro OFX UI, it shows the frame range starting at 0. By adding this value, it can show the same frame numbers. On Tue, Nov 12, 2019, 5:38 PM GaryO ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In include/ofxImageEffect.h > <#67 (comment)>: > > > @@ -929,6 +929,16 @@ then the plugin can detect this via an identifier change and re-evaluate the cac > */ > #define kOfxImagePropUniqueIdentifier "OfxImagePropUniqueIdentifier" > > +/** @brief Clip property which indicates the display start frame of the clip > + > + - Type - double X 1 > + - Property Set - clip instance (read only) > + - Default - 0 > + > +This value should be added to the internal frame number when displayed in a plugin user interface > > ..., so that the user sees the same frame number as they see in the host > UI. (?) > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > < #67 >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAM64ASENPG7GUZ63QDYSZ3QTM5AZANCNFSM4JMILA4Q > > . > On Tue, Nov 12, 2019, 5:38 PM GaryO ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In include/ofxImageEffect.h > <#67 (comment)>: > > > @@ -929,6 +929,16 @@ then the plugin can detect this via an identifier change and re-evaluate the cac > */ > #define kOfxImagePropUniqueIdentifier "OfxImagePropUniqueIdentifier" > > +/** @brief Clip property which indicates the display start frame of the clip > + > + - Type - double X 1 > + - Property Set - clip instance (read only) > + - Default - 0 > + > +This value should be added to the internal frame number when displayed in a plugin user interface > > ..., so that the user sees the same frame number as they see in the host > UI. (?) > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > < #67 >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAM64ASENPG7GUZ63QDYSZ3QTM5AZANCNFSM4JMILA4Q > > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#67>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABCFR522EY3T2KXXHQ5Q4LQTNHKBANCNFSM4JMILA4Q> .

[revisionfx]

Sorry isn't this something that should be in timeline suite?
And also as mentioned earlier if param is of type ofxTime shouldn't it allows you to display in timeline time and report in effects time? SO if one moves clip on timeline, ofxTime internally stays at same frame in effects local time but shows the new timeline time?

[fxtech]

This could probably be done with the Timeline suite. I thought adding a property is less "heavy" than adding a function to a suite. Would be good to discuss.