Skip to content

build: wasm build#5304

Merged
lgritz merged 1 commit into
AcademySoftwareFoundation:mainfrom
nickdademo:fix_wasm_build
Jul 8, 2026
Merged

build: wasm build#5304
lgritz merged 1 commit into
AcademySoftwareFoundation:mainfrom
nickdademo:fix_wasm_build

Conversation

@nickdademo

@nickdademo nickdademo commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Description

Tests

Checklist:

  • I have read the guidelines on contributions and code review procedures.
  • I have read the Policy on AI Coding Assistants
    and if I used AI coding assistants, I have an Assisted-by: TOOL / MODEL
    line in the pull request description above.
  • I have updated the documentation if my PR adds features or changes
    behavior.
  • I am sure that this PR's changes are tested in the testsuite.
  • I have run and passed the testsuite in CI before submitting the
    PR, by pushing the changes to my fork and seeing that the automated CI
    passed there. (Exceptions: If most tests pass and you can't figure out why
    the remaining ones fail, it's ok to submit the PR and ask for help. Or if
    any failures seem entirely unrelated to your change; sometimes things break
    on the GitHub runners.)
  • My code follows the prevailing code style of this project and I
    fixed any problems reported by the clang-format CI test.
  • If I added or modified a public C++ API call, I have also amended the
    corresponding Python bindings. If altering ImageBufAlgo functions, I also
    exposed the new functionality as oiiotool options.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 7, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: nickdademo / name: Nick D'Ademo (938800b)

Signed-off-by: Nick D'Ademo <nickdademo@gmail.com>
@nickdademo nickdademo changed the title Fix WASM build fix: wasm build Jul 7, 2026
@lgritz lgritz changed the title fix: wasm build build: wasm build Jul 7, 2026

@lgritz lgritz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that at present, we don't CI test building for wasm. But if you want to submit a change to the CI scripts to do it (assuming that's possible on GHA), that would be a welcome addition as well.

@nickdademo

Copy link
Copy Markdown
Contributor Author

LGTM

Note that at present, we don't CI test building for wasm. But if you want to submit a change to the CI scripts to do it (assuming that's possible on GHA), that would be a welcome addition as well.

Thanks! Good idea - perhaps in a separate follow up PR :)

@lgritz lgritz merged commit 14e30d8 into AcademySoftwareFoundation:main Jul 8, 2026
29 checks passed
@pjebs

pjebs commented Jul 8, 2026

Copy link
Copy Markdown

@nickdademo PJ from monash. What is this PR for? Are you building something special?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants