fix(sgi): prevent oversized-allocation crash from bogus RLE length/offset table#5303
Open
lgritz wants to merge 1 commit into
Open
fix(sgi): prevent oversized-allocation crash from bogus RLE length/offset table#5303lgritz wants to merge 1 commit into
lgritz wants to merge 1 commit into
Conversation
…fset table Truncating a corrupt uint32 length_tab entry into `int` could yield a huge negative value, causing a runaway allocation and crash in uncompress_rle_channel. Validate offset/length against the file size instead. Assisted-by: Claude Code / Sonnet 5 Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truncating a corrupt uint32 length_tab entry into
intcould yield a huge negative value, causing a runaway allocation and crash in uncompress_rle_channel. Validate offset/length against the file size instead.Assisted-by: Claude Code / Sonnet 5