fix: Remove redundant declarations#5210
Merged
Merged
Conversation
This is an emergency fix for 5201. I truly do not understand how this happened. PR 5201 passed CI completely! Then I merged it, and now it fails. OOOOOOH. The imagespeed_test.cpp is not compiled at all for CI! Only for local builds. So a build break in it will not be caught in CI. OK, fixing that, too. It doesn't run in CI, it's not that kind of test, it's a special benchmarking test meant to run locally and needs to be told a specific image file to test with. But at least build it for CI so we can't inadvertently break it again. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
Merging immediately to fix badly broken build, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an emergency fix on top of #5201.
PR 5201 passed CI completely. Then I merged it, and now it fails. How did that happen?
OOOOOOH. The imagespeed_test.cpp is not compiled at all for CI! Only for local builds. So a build break in it will not be caught in CI. OK, fixing that, too. It doesn't run in CI, it's not that kind of test, it's a special benchmarking test meant to run locally and needs to be told a specific image file to test with. But at least build it for CI so we can't inadvertently break it again.