fix(heif): Invalid read writing 8bit and dimensions not a multiple of 64#5095
Merged
lgritz merged 1 commit intoAcademySoftwareFoundation:mainfrom Mar 18, 2026
Merged
Conversation
Don't coy from memory using the stride, as this can get padded and read past the end of the input pixel data. The 10 and 12 bit paths were correct. Signed-off-by: Brecht Van Lommel <brecht@blender.org>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Mar 19, 2026
… 64 (AcademySoftwareFoundation#5095) Don't copy from memory using the stride, as this can get padded and read past the end of the input pixel data. The 10 and 12 bit paths were correct. Test added, this only failed with address sanitizer. Signed-off-by: Brecht Van Lommel <brecht@blender.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't coy from memory using the stride, as this can get padded and read past the end of the input pixel data. The 10 and 12 bit paths were correct.
Tests
Test added, this only failed with address sanitizer.
Checklist:
behavior.
testsuite.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.
corresponding Python bindings. If altering ImageBufAlgo functions, I also
exposed the new functionality as oiiotool options.