Align smoothstep edge cases with OSL#1985
Merged
jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom Sep 5, 2024
Merged
Align smoothstep edge cases with OSL#1985jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom
jstone-lucasfilm merged 3 commits intoAcademySoftwareFoundation:mainfrom
Conversation
pablode
reviewed
Aug 22, 2024
jstone-lucasfilm
approved these changes
Sep 5, 2024
Member
jstone-lucasfilm
left a comment
jstone-lucasfilm
left a comment
There was a problem hiding this comment.
Thanks for this fix, @ld-kerley, and this looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following a conversation on ASWF slack this PR was posted to OSL refining the edge cases for
smoothstep().AcademySoftwareFoundation/OpenShadingLanguage#1851
This PR aligns the GLSL/MSL code with this change.
Before merging we need to decide...
The MaterialX specification currently does not specify an opinion about the edges cases here, but I'm going to leave that to up coming specification refinement to add normative language to handle.