feat: add remaining unit tests for cps-ui-kit#702
Open
fateeand wants to merge 1 commit into
Open
Conversation
fateeand
requested review from
TerranceKhumalo-absa,
korel-san and
lukasmatta
as code owners
Contributor
Coverage report for library
Test suite run success2368 tests passing in 76 suites. Report generated by 🧪jest coverage report action from 2f2cd1b |
Contributor
Playwright test results
Details
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the remaining unit tests for several cps-ui-kit components/directives/pipes and introduces/relocates a few internal utility modules (size, motion, accessibility, colors), updating deep-import paths across the kit accordingly.
Changes:
- Added new internal utilities (
size-utils,motion-utils,accessibility-utils,colors-utils) plus Jest unit tests. - Added/covered additional internal pipes and directives (e.g., option/label pipes, click-outside, table/tree-table unsort) with new tests.
- Updated a broad set of components to import the new utility/pipes/directives file paths and adjusted
public-apiexports.
Reviewed changes
Copilot reviewed 57 out of 68 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| projects/cps-ui-kit/src/public-api.ts | Update exported entrypoints for moved utils/dialog ref |
| projects/cps-ui-kit/src/lib/utils/internal/size-utils/size-utils.ts | Add internal size parsing/normalization helpers |
| projects/cps-ui-kit/src/lib/utils/internal/size-utils/size-utils.spec.ts | Unit tests for size utils |
| projects/cps-ui-kit/src/lib/utils/internal/motion-utils/motion-utils.ts | Add reduced-motion helpers |
| projects/cps-ui-kit/src/lib/utils/internal/motion-utils/motion-utils.spec.ts | Unit tests for motion utils |
| projects/cps-ui-kit/src/lib/utils/internal/accessibility-utils/accessibility-utils.ts | Add internal accessibility helpers (ids/focus/aria logging) |
| projects/cps-ui-kit/src/lib/utils/internal/accessibility-utils/accessibility-utils.spec.ts | Unit tests for accessibility utils |
| projects/cps-ui-kit/src/lib/utils/colors-utils/colors-utils.ts | Add color extraction/contrast helpers |
| projects/cps-ui-kit/src/lib/utils/colors-utils/colors-utils.spec.ts | Unit tests for colors utils |
| projects/cps-ui-kit/src/lib/services/cps-notification/internal/components/cps-toast/cps-toast.component.ts | Update deep imports for size/motion utils |
| projects/cps-ui-kit/src/lib/services/cps-dialog/utils/cps-dialog-ref/cps-dialog-ref.ts | Fix dialog component import path |
| projects/cps-ui-kit/src/lib/services/cps-dialog/utils/cps-dialog-ref/cps-dialog-ref.spec.ts | Add unit tests for CpsDialogRef |
| projects/cps-ui-kit/src/lib/services/cps-dialog/internal/components/cps-dialog/cps-dialog.component.ts | Update deep imports (size/motion/dialog-ref) |
| projects/cps-ui-kit/src/lib/services/cps-dialog/internal/components/cps-dialog/cps-dialog.component.spec.ts | Update dialog-ref import path for tests |
| projects/cps-ui-kit/src/lib/services/cps-dialog/internal/components/cps-confirmation/cps-confirmation.component.ts | Update dialog-ref import path; remove no-useless-constructor suppression |
| projects/cps-ui-kit/src/lib/services/cps-dialog/internal/components/cps-confirmation/cps-confirmation.component.spec.ts | Update dialog-ref import path for tests |
| projects/cps-ui-kit/src/lib/services/cps-dialog/cps-dialog.service.ts | Update dialog-ref import path |
| projects/cps-ui-kit/src/lib/services/cps-dialog/cps-dialog.service.spec.ts | Update dialog-ref import path for tests |
| projects/cps-ui-kit/src/lib/pipes/internal/label-by-value/label-by-value.pipe.ts | Add label-by-value pipe implementation |
| projects/cps-ui-kit/src/lib/pipes/internal/label-by-value/label-by-value.pipe.spec.ts | Unit tests for label-by-value pipe |
| projects/cps-ui-kit/src/lib/pipes/internal/combine-labels/combine-labels.pipe.ts | Add combine-labels pipe implementation |
| projects/cps-ui-kit/src/lib/pipes/internal/combine-labels/combine-labels.pipe.spec.ts | Unit tests for combine-labels pipe |
| projects/cps-ui-kit/src/lib/pipes/internal/check-option-selected/check-option-selected.pipe.ts | Add option-selected pipe implementation |
| projects/cps-ui-kit/src/lib/pipes/internal/check-option-selected/check-option-selected.pipe.spec.ts | Unit tests for option-selected pipe |
| projects/cps-ui-kit/src/lib/directives/internal/click-outside/click-outside.directive.ts | Add click-outside directive implementation |
| projects/cps-ui-kit/src/lib/directives/internal/click-outside/click-outside.directive.spec.ts | Unit tests for click-outside directive |
| projects/cps-ui-kit/src/lib/directives/cps-tooltip/cps-tooltip.directive.ts | Update deep imports for size utils |
| projects/cps-ui-kit/src/lib/components/internal/cps-base-tree-dropdown/cps-base-tree-dropdown.component.ts | Update deep imports (accessibility/size utils) |
| projects/cps-ui-kit/src/lib/components/internal/cps-base-tree-dropdown/cps-base-tree-dropdown.component.spec.ts | Update combine-labels pipe import path |
| projects/cps-ui-kit/src/lib/components/cps-tree-table/directives/internal/tree-table-unsort/tree-table-unsort.directive.ts | Add TreeTable unsort directive (PrimeNG patching) |
| projects/cps-ui-kit/src/lib/components/cps-tree-table/directives/internal/tree-table-unsort/tree-table-unsort.directive.spec.ts | Unit tests for TreeTable unsort directive |
| projects/cps-ui-kit/src/lib/components/cps-tree-table/cps-tree-table.component.ts | Update deep imports (size utils, unsort directive) |
| projects/cps-ui-kit/src/lib/components/cps-tree-select/cps-tree-select.component.ts | Update combine-labels pipe import path |
| projects/cps-ui-kit/src/lib/components/cps-tree-select/cps-tree-select.component.spec.ts | Update combine-labels pipe import path for tests |
| projects/cps-ui-kit/src/lib/components/cps-timepicker/cps-timepicker.component.ts | Update accessibility utils import path |
| projects/cps-ui-kit/src/lib/components/cps-textarea/cps-textarea.component.ts | Update deep imports (size + accessibility utils) |
| projects/cps-ui-kit/src/lib/components/cps-tag/cps-tag.component.ts | Update colors utils import path |
| projects/cps-ui-kit/src/lib/components/cps-table/directives/internal/table-unsort/table-unsort.directive.ts | Add Table unsort directive (PrimeNG patching) |
| projects/cps-ui-kit/src/lib/components/cps-table/directives/internal/table-unsort/table-unsort.directive.spec.ts | Unit tests for Table unsort directive |
| projects/cps-ui-kit/src/lib/components/cps-table/cps-table.component.ts | Update deep imports (size utils, unsort directive) |
| projects/cps-ui-kit/src/lib/components/cps-table/components/internal/table-column-visibility-toggle/table-column-visibility-toggle.component.ts | Update accessibility utils import path |
| projects/cps-ui-kit/src/lib/components/cps-tab-group/cps-tab/cps-tab.component.ts | Update accessibility utils import path |
| projects/cps-ui-kit/src/lib/components/cps-tab-group/cps-tab-group.component.ts | Update deep imports (colors/accessibility/motion utils) |
| projects/cps-ui-kit/src/lib/components/cps-switch/cps-switch.component.ts | Update accessibility utils import path |
| projects/cps-ui-kit/src/lib/components/cps-sidebar-menu/cps-sidebar-menu.component.ts | Update deep imports (size/motion utils) |
| projects/cps-ui-kit/src/lib/components/cps-select/cps-select.component.ts | Update deep imports (size/accessibility + pipe paths) |
| projects/cps-ui-kit/src/lib/components/cps-select/cps-select.component.spec.ts | Update pipe import paths for tests |
| projects/cps-ui-kit/src/lib/components/cps-radio-group/cps-radio/cps-radio.component.spec.ts | Add unit tests for CpsRadioComponent |
| projects/cps-ui-kit/src/lib/components/cps-radio-group/cps-radio-group.component.ts | Update accessibility utils import path |
| projects/cps-ui-kit/src/lib/components/cps-radio-group/cps-radio-button/cps-radio-button.component.ts | Update accessibility utils import path |
| projects/cps-ui-kit/src/lib/components/cps-radio-group/cps-radio-button/cps-radio-button.component.spec.ts | Add unit tests for CpsRadioButtonComponent |
| projects/cps-ui-kit/src/lib/components/cps-progress-linear/cps-progress-linear.component.ts | Update deep imports (colors + size utils) |
| projects/cps-ui-kit/src/lib/components/cps-progress-circular/cps-progress-circular.component.ts | Update deep imports (colors + size utils) |
| projects/cps-ui-kit/src/lib/components/cps-paginator/cps-paginator.component.ts | Update colors utils import path |
| projects/cps-ui-kit/src/lib/components/cps-menu/cps-menu.component.ts | Update motion utils import path; type-only import tweak |
| projects/cps-ui-kit/src/lib/components/cps-loader/cps-loader.component.ts | Update deep imports (colors + accessibility utils) |
| projects/cps-ui-kit/src/lib/components/cps-input/cps-input.component.ts | Update deep imports (size + accessibility utils); type-only import tweak |
| projects/cps-ui-kit/src/lib/components/cps-info-circle/cps-info-circle.component.spec.ts | Add unit tests for CpsInfoCircleComponent |
| projects/cps-ui-kit/src/lib/components/cps-icon/cps-icon.component.ts | Update deep imports (colors + size utils) |
| projects/cps-ui-kit/src/lib/components/cps-file-upload/cps-file-upload.component.ts | Update deep imports (size + accessibility utils); type-only import tweak |
| projects/cps-ui-kit/src/lib/components/cps-expansion-panel/cps-expansion-panel.component.ts | Update deep imports (colors/size/accessibility/motion utils) |
| projects/cps-ui-kit/src/lib/components/cps-divider/cps-divider.component.ts | Update deep imports (colors + size utils) |
| projects/cps-ui-kit/src/lib/components/cps-datepicker/cps-datepicker.component.ts | Update deep imports (size + accessibility utils) |
| projects/cps-ui-kit/src/lib/components/cps-checkbox/cps-checkbox.component.ts | Update deep imports (colors + accessibility utils) |
| projects/cps-ui-kit/src/lib/components/cps-button/cps-button.component.ts | Update deep imports (colors/size/accessibility utils); type-only import tweak |
| projects/cps-ui-kit/src/lib/components/cps-button-toggle/cps-button-toggle.component.ts | Update pipe + accessibility utils import paths |
| projects/cps-ui-kit/src/lib/components/cps-autocomplete/cps-autocomplete.component.ts | Update deep imports (size/accessibility + pipe paths) |
| projects/cps-ui-kit/src/lib/components/cps-autocomplete/cps-autocomplete.component.spec.ts | Update pipe import paths for tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR is adding unit tests for:
CpsInfoCircleComponentCpsRadioComponentCpsRadioButtonComponentCpsDialogRefClickOutsideDirectiveCheckOptionSelectedPipeCombineLabelsPipeLabelByValuePipeTableUnsortDirectiveTreeTableUnsortDirectiveRelease notes: