-
Notifications
You must be signed in to change notification settings - Fork 0
EventGate Lambda entrypoint OOP #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
068ad29
HandlerApi created top collect all API endpoint related logic
tmikula-dev ffc707b
Main script refactor
tmikula-dev 8d282e9
Updated project test files
tmikula-dev d05b539
CodeRabbit comment fix.
tmikula-dev fad1a68
Merge branch 'master' into feature/105-lambda-module-oop
tmikula-dev b49d23d
Comment changes.
tmikula-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| # | ||
| # Copyright 2026 ABSA Group Limited | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| """ | ||
| This module provides the HandlerApi class for serving the OpenAPI specification. | ||
| """ | ||
|
|
||
| import logging | ||
| import os | ||
| from typing import Dict, Any | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class HandlerApi: | ||
| """ | ||
| HandlerApi manages the OpenAPI specification endpoint. | ||
| """ | ||
|
|
||
| def __init__(self): | ||
| self.api_spec: str = "" | ||
|
|
||
| def load_api_definition(self) -> "HandlerApi": | ||
| """ | ||
| Load the OpenAPI specification from api.yaml file. | ||
|
|
||
| Returns: | ||
| HandlerApi: The current instance with loaded API definition. | ||
| """ | ||
| project_root = os.path.abspath(os.path.join(os.path.dirname(__file__), "../..")) | ||
| api_path = os.path.join(project_root, "api.yaml") | ||
|
|
||
| with open(api_path, "r", encoding="utf-8") as file: | ||
| self.api_spec = file.read() | ||
| logger.debug("Loaded API definition from %s", api_path) | ||
| return self | ||
|
|
||
| def get_api(self) -> Dict[str, Any]: | ||
| """ | ||
| Return the OpenAPI specification. | ||
|
|
||
| Returns: | ||
| Dict[str, Any]: API Gateway response with OpenAPI spec. | ||
| """ | ||
| logger.debug("Handling GET API") | ||
|
oto-macenauer-absa marked this conversation as resolved.
|
||
| return { | ||
| "statusCode": 200, | ||
| "headers": {"Content-Type": "application/yaml"}, | ||
| "body": self.api_spec, | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # | ||
| # Copyright 2026 ABSA Group Limited | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| import pytest | ||
| from unittest.mock import patch, mock_open | ||
|
|
||
| from src.handlers.handler_api import HandlerApi | ||
|
|
||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| def test_load_api_definition_success(): | ||
| """Test successful loading of API definition.""" | ||
| mock_content = "openapi: 3.0.0\ninfo:\n title: Test API" | ||
| with patch("builtins.open", mock_open(read_data=mock_content)): | ||
| handler = HandlerApi().load_api_definition() | ||
| assert handler.api_spec == mock_content | ||
|
|
||
|
|
||
| def test_load_api_definition_file_not_found(): | ||
| """Test that FileNotFoundError is raised when api.yaml doesn't exist.""" | ||
| with patch("builtins.open", side_effect=FileNotFoundError("api.yaml not found")): | ||
| handler = HandlerApi() | ||
| with pytest.raises(FileNotFoundError): | ||
| handler.load_api_definition() | ||
|
|
||
|
|
||
| def test_get_api_returns_correct_response(): | ||
| """Test get_api returns correct response structure.""" | ||
| mock_content = "openapi: 3.0.0" | ||
| with patch("builtins.open", mock_open(read_data=mock_content)): | ||
| handler = HandlerApi().load_api_definition() | ||
| response = handler.get_api() | ||
|
|
||
| assert response["statusCode"] == 200 | ||
| assert response["headers"]["Content-Type"] == "application/yaml" | ||
| assert response["body"] == mock_content | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.