Introduce scalafmt#146
Open
ddworak wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces scalafmt to scex (config + plugin + one-shot reformat). No CI enforcement gate yet — that's a deliberate follow-up so this large mechanical diff can be reviewed on its own.
.scalafmt.confbased on the shared AVSystem config (as used in scala-commons), with two deliberate differences:runner.dialect = scala213(notScala213Source3) — scex does not compile with-Xsource:3.RedundantParensis omitted from the rewrite rules. scex is existential-type-heavy, and that rule strips parens that are syntactically required aroundT forSome { ... }types in lambda-parameter ascriptions, producing code that no longer parses (hit inValidationTest.scalaandScexCompilerTest.scala). Documented inline in the config.sbt-scalafmt2.6.1 toproject/plugins.sbt.scalafmtAll+scalafmtSbt): 123 files..git-blame-ignore-revspointing at the reformat commit sogit blameskips it.Commits
Kept separate for review: setup (config + plugin) → pure reformat → blame-ignore.
Test plan
sbt scalafmtCheckAll scalafmtSbtCheckpasses after reformatsbt compile Test/compilepasses (verifies the rewrite rules didn't break anything)Follow-up
A separate PR will add the CI enforcement step (mirroring scala-commons / intellij-hocon).