Implementation of the algorithm to find the experimental Bragg curves from the AtTracks. by RealAurio · Pull Request #257 · ATTPC/ATTPCROOTv2

RealAurio · 2025-08-04T19:38:32Z

Added container in AtTrack in order to store the experimental values of (range, eLoss).

Added a base class for possible classes that modify a given AtPatternEvent.

Added the task to apply AtPatternModifications to the AtPatternEvents.

Added the option to pass AtEvent and AtRawEvent to the AtPatternModification.

Added a virtual method to the base class AtPattern that computes the distance between 2 points along the pattern. Implemented it for the case of AtPatternLine.

Implemented a virtual method in base class AtPattern to obtain the parameter at a given point of the AtPattern.

Modified the AtPSAHitPerTB.

Implemented an AtPatternModification which extracts the pair of values for the Bragg curve reconstruction and saves them in the AtTracks.

Added quick test macros to check if this feature works so far.

Generated the Bragg curve histogram and saved it in a new BraggCurve struct in AtTrack.

Added an AtTab to visualize the Bragg curves of the AtTacks.

Implemented the smoothing of the Bragg curves.

…of (range, eLoss). Added a base class for possible classes that modify a given AtPatternEvent. Added the task to apply AtPatternModifications to the AtPatternEvents. Oops. Added the option to pass AtEvent and AtRawEvent to the AtPatternModification. Added a virtual method to the base class AtPattern that computes the distance between 2 points along the pattern. Implemented it for the case of AtPatternLine. Implemented a virtual method in base class AtPattern to obtain the parameter at a given point of the AtPattern. Modified the AtPSAHitPerTB. Forgot to change version number. Implemented an AtPatternModification which extracts the pair of values for the Bragg curve reconstruction and saves them in the AtTracks. The AtPatternModifications need to be able to write to disk. Added quick test macros to check if this feature works so far. Generated the Bragg curve histogram and saved it in a new BraggCurve struct in AtTrack. Added an AtTab to visualize the Bragg curves of the AtTacks. Implemented the smoothing of the Bragg curves.

anthoak13

I think we want to tweak the interface for pattern modification and the associated task

AtData/AtPattern/AtPattern.h

AtData/AtPattern/AtPatternLine.cxx

AtData/AtPattern/AtPatternLine.h

AtData/AtTrack.h

AtReconstruction/AtPatternModificationTask.cxx

AtReconstruction/AtPatternModification/AtPatternModification.cxx

AtReconstruction/AtPatternModification/AtBraggCurveFinder.cxx

AtReconstruction/AtPulseAnalyzer/AtPSAHitPerTB.cxx

…ges were needed in AtBraggCurveFinder.

…aybe something else, but it has been 2 weeks and I do not remember...

… AtPatternEvent with the modified one and other changes.

anthoak13

I think this looks good with a few tiny comments. The big one is I don't remember the discussion on moving the brag-curve specific parts to their own derived class.

AtData/AtTrack.h

anthoak13 · 2025-09-03T23:27:02Z

AtReconstruction/AtPatternModification/AtPatternModification.cxx

@@ -0,0 +1,17 @@
+#include "AtPatternModification.h"
+
+void AtPatternModification::ModifyPatternEvent(AtPatternEvent *patternEvent, AtRawEvent *rawEvent, AtEvent *event)


Should either check for null pointers or we should pass AtPatternEvent as a reference rather than a pointer

anthoak13 · 2025-09-03T23:28:25Z

AtReconstruction/AtPatternModification/AtPatternModification.cxx

+
+   // Iterate over the original tracks and store the modified ones.
+   for (auto track : tracks)
+      modifiedTracks.push_back(GetModifiedTrack(&track, rawEvent, event));


Since we just have references anyway, GetModifiedTrack should probably take a reference rather than a pointer.

This use makes me think it should be a constant reference as well (we are returning a new track)

Yeah, initially I just modified the AtTrack, but since we now want to keep the original AtPatternEvent, I can't just modify them.

Also, by returning a different AtTrack, this would allow this function to get a normal AtTrack and return a derived one, in the future when we implement derived AtTracks. But as mentioned earlier, this gave me problems, so for now I'll just work with normal AtTracks.

I will make it so that the input is a const reference to the original AtTrack.

AtReconstruction/AtPatternModificationTask.cxx

anthoak13 · 2025-09-03T23:30:23Z

AtReconstruction/AtPatternModificationTask.h

+#include <utility>
+#include <vector>
+
+class AtPatternModificationTask : public FairTask {


Should have a doxygen comment explaining this copies event to new branch and modifies each track.

anthoak13 · 2025-09-03T23:31:51Z

AtReconstruction/AtPatternModificationTask.h

+   TString fInputBranchName;
+   TString fOutputBranchName;
+   TString fRawEventBranchName;
+   TString fEventBranchName;


Should have default values for input and output branch name, or those should required parts of the constructor. The class doesn't make sense as an object without them set. Best practices has an object functional an initialization, then use function calls to modify behavior

I have already commented on this, but forgot to press publish review.

I see in a lot of tasks, the default values are given in the constructor of the task, so that's why I put those there. In any case, I will also put the defaults here too even if it's redundant.

RealAurio

My comments that I forgot to submit...

AtData/AtPattern/AtPatternLine.h

AtData/AtPattern/AtPattern.h

AtData/AtPattern/AtPatternLine.cxx

RealAurio · 2025-08-05T19:20:30Z

AtData/AtTrack.h

+   // Obtained in AtPatternModification
+   // Vector of pair of values for the Bragg curve of the track (archLength[mm], eLoss[a.u.]).
+   std::vector<std::pair<Double_t, Double_t>> fBraggCurveValues;
+   // Container for the Bragg curve integrated over the binning.
+   BraggCurve fBraggCurve;


Yeah, maybe makes sense. AtPatternEvent should still work with these I guess.

AtReconstruction/AtPatternModificationTask.h

AtReconstruction/AtPulseAnalyzer/AtPSAHitPerTB.cxx

RealAurio · 2025-08-28T18:12:47Z

AtReconstruction/AtReconstructionLinkDef.h

+#pragma link C++ class AtPatternModification + ;
+#pragma link C++ class AtBraggCurveFinder + ;
+#pragma link C++ class AtPatternModificationTask + ;


AtPatternModification and AtBraggCurveFinder can be - !, but AtPatternModificationTask needs to be +, or else it does not compile. Also, other tasks are saved as + here.

AtData/AtTrack.h

anthoak13

I think this is ready to merge!

anthoak13 requested changes Aug 5, 2025

View reviewed changes

anthoak13 mentioned this pull request Aug 5, 2025

Implemented the 3D Bragg curve fitter using CATima #250

Closed

RealAurio added 6 commits August 13, 2025 10:38

Requested changes regarding AtData/AtPattern. Due to those, some chan…

b5bf1f3

…ges were needed in AtBraggCurveFinder.

Added changes regarding the interface of the AtPatternModification. M…

64b3662

…aybe something else, but it has been 2 weeks and I do not remember...

Implemented requested changes regarding AtTrack and AtTabBraggCurve.

eb3fc7d

Added last requested changes regarding the saving both the unmodified…

0321fed

… AtPatternEvent with the modified one and other changes.

clang-formatted.

df82291

clang-formatted 2.

bf01ba7

RealAurio mentioned this pull request Sep 2, 2025

Tentative changes for new base class AtFittedTrack. #254

Open

anthoak13 requested changes Sep 3, 2025

View reviewed changes

RealAurio commented Sep 5, 2025

View reviewed changes

RealAurio added 2 commits September 5, 2025 10:19

Added the eventDisplay macro to visualise the MC results.

d0e07b8

Last changes.

491c91e

RealAurio force-pushed the experimentalBraggCurve branch from 69ab616 to 491c91e Compare September 5, 2025 08:52

anthoak13 approved these changes Sep 5, 2025

View reviewed changes

anthoak13 merged commit 7ff3909 into ATTPC:develop Sep 5, 2025
2 checks passed

RealAurio mentioned this pull request Sep 9, 2025

Implemented a way to invert the drift velocity direction inside the ATTPC. Also fixed the padplane-projected hits issue by adding a charge threshold... #258

Open

		@@ -0,0 +1,17 @@
		#include "AtPatternModification.h"

		void AtPatternModification::ModifyPatternEvent(AtPatternEvent patternEvent, AtRawEvent rawEvent, AtEvent *event)

Comments

Conversation

RealAurio commented Aug 4, 2025

Uh oh!

anthoak13 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anthoak13 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RealAurio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

anthoak13 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants