new shuffle feature #227
new shuffle feature #227
Conversation
assets/js/modules.js
Outdated
| this.addSorting(); | ||
| this.addSearchFilter(); | ||
|
|
||
| // ✅ ÄNDERUNG: Initiale Random-Darstellung – NUR EINMAL |
There was a problem hiding this comment.
please add documentation in English
| // ✅ ÄNDERUNG: Initiale Random-Darstellung – NUR EINMAL | ||
| // Wichtig: nach Initialisierung, bevor User interagiert | ||
| requestAnimationFrame(() => { | ||
| this.shuffle.sort({ randomize: true }); |
There was a problem hiding this comment.
I think this I am not sure this helps, in case to repeat training configurations this maximizes workload for the traininer/curator
There was a problem hiding this comment.
I am also not sure about this. What problem are you trying to solve @walthierer ? How will this improve the platform?
There was a problem hiding this comment.
Is this the only change you made @walthierer that affects the functioning of the app? I see a lot of changes but most of them are just syntactic sugar
There was a problem hiding this comment.
Hello Linus,
It's not really a problem that needs solving. The project manager just requested that the modules on the landing page be rearranged. The reason for this is that the #ASKnet project is coming to an official end according to the funding perspective, so all the outputs, like the ASKtraining platform, will be presented to the founders. The idea behind rearranging the display of the modules was to liven up the landing page and not always show the same two #ASKotec images.
There was a problem hiding this comment.
So, I created this 'feature' to demonstrate what it could look like.
BUT, nothing has been agreed yet, so please DON'T do anything for now.
Sorry for the poor programming sugar syntax – I'm not a professional!
There was a problem hiding this comment.
I only made changes to the module.js file.
There was a problem hiding this comment.
So, I created this 'feature' to demonstrate what it could look like. BUT, nothing has been agreed yet, so please DON'T do anything for now. Sorry for the poor programming sugar syntax – I'm not a professional!
No problem with the syntax sugar. Just,
if it ain't broke, don't fix it 😃
|
I think this change has too many changes, that are not only aiming at the shuffle mode. It changes the internal structure of the platform view and caching/saving the selection. I am not 100% sure how to fix that properly, might be due to not up to date branch? @saisilinus could you have a quick look on this |
|
Please add a description for the PR @walthierer. You can use this template as a guideline: Pull RequestDescriptionPlease include a summary of the change and which issue is fixed. Please also include relevant motivation and context. Fixes # (issue) Type of changePlease delete options that are not relevant.
How Has This Been Tested?Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:
|
|
good Idea with #229 ... for now if you could help implementing a set switch button to "shuffle" would be awesome @saisilinus - I think this way one can still switch to "regular" unshuffled mode if needed You can use the feature branch @walthierer created |
|
Ok |
Revised the module.js file to enable different displays of the modules after the website is reloaded.