Merged
Conversation
jhkennedy
reviewed
Feb 27, 2026
Comment on lines
+4
to
+9
| job_name: | ||
| api_schema: | ||
| description: Project name with the multiburst jobs. | ||
| type: string | ||
| nullable: true | ||
| default: null |
Contributor
There was a problem hiding this comment.
Hmm, it's a little weird to have the job['job_parameters']['job_name'] here, when it's also at job['name']. I wonder if we could pipe it in directly, or do you want them to be different?
project_name might be a better parameter name here as well.
Contributor
There was a problem hiding this comment.
I think this also might be redundant with input_prefix, no?
Contributor
Author
There was a problem hiding this comment.
Thanks Joe!! I address your comments and remove the input_bucket parameter from the plugin and job spec. The input_prefix is different to the publish_prefix so I prefer to keep both of them.
jhkennedy
previously approved these changes
Feb 28, 2026
jhkennedy
approved these changes
Feb 28, 2026
github-project-automation
Bot
moved this from Needs Review
to Done
in SciDev Team Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a job spec for hyp3-mintpy