Skip to content

clamp angular weight span before narrowing to int #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sahvx655-wq wants to merge 1 commit into from
Closed

clamp angular weight span before narrowing to int #649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Source/astcenc_weight_align.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,13 @@ static void compute_lowest_and_highest_weight(
cut_high_weight_err = select(cut_high_weight_err, accum, mask);
}

// Write out min weight and weight span; clamp span to a usable range
vint span = float_to_int(maxidx - minidx + vfloat(1));
// Write out min weight and weight span; clamp span to a usable range.
// The span is derived from the ideal weights, which are non-finite when
// the input texels are non-finite, so clamp into the representable result
// range before narrowing to avoid an out-of-range float to int conversion
vfloat spanf = clamp(0.0f, static_cast<float>(max_quant_steps + 3),
maxidx - minidx + vfloat(1));
vint span = float_to_int(spanf);
span = min(span, vint(max_quant_steps + 3));
span = max(span, vint(2));
storea(minidx, lowest_weight + sp);
Expand Down
Loading