Clamp HDR endpoint spread before narrowing it to int#645
Merged
Conversation
solidpixel
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-quant-level format search in
compute_color_error_for_every_integer_count_and_quant_levelestimates the likely RGB and RGBO submodes from the colour spread of the decoded endpoints, casting the three spread valuesbf,cfanddfstraight toint. The endpoints can fall a long way outside the input range, and an HDR image loaded through the fp16 path keeps any overexposed infinities or NaNs the source carried, so the spread is not bounded byINT_MAX. Feeding a crafted fp16.ktxthrough-chmakes UBSan flag all three conversions withruntime error: <value> is outside the range of representable values of type 'int', and the integer that comes back is whatever the platform conversion happens to emit.b,canddare only read by the threshold tests that choose the submode and the largest threshold is 32768, so clamping each spread into[0, 65536]before the narrowing cast leaves every comparison result unchanged for in-range data while making the out-of-range case well defined.astc::clampfolds NaN to its low bound, so a non-finite spread drops into the small-value branch rather than into undefined behaviour. The bound lives at the conversion because that is the only place the value is narrowed; the endpoint maths upstream is left alone, and encoded output is byte-identical for valid images.