Skip to content

fix out-of-bounds write in store_dds_uncompressed_image for 3d ldr #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solidpixel merged 3 commits into from
Jun 13, 2026
Merged

fix out-of-bounds write in store_dds_uncompressed_image for 3d ldr #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3da4034
use dim_x for ldr plane stride in store_dds_uncompressed_image
sahvx655-wq Jun 13, 2026
3a40417
Avoid backwards ordering
solidpixel Jun 13, 2026
20e7816
Add changelog
solidpixel Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Docs/ChangeLog-5x.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,17 @@ release of the 5.x series.
All performance data on this page is measured on an Intel Core i5-9600K
clocked at 4.2 GHz, running `astcenc` using AVX2 and 6 threads.

<!-- ---------------------------------------------------------------------- -->
## 5.6.0

**Status:** In development

The 5.6.0 release is a minor maintenance release.

* **Command line tool updates:**
* **Bug fix:** Fixed incorrect plane stride when writing an uncompressed 3D
LDR image to a DDS container.

<!-- ---------------------------------------------------------------------- -->
## 5.5.0

Expand Down
8 changes: 4 additions & 4 deletions Source/astcenccli_image_load_store.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1550,7 +1550,7 @@ static bool store_ktx_uncompressed_image(
for (unsigned int z = 1; z < dim_z; z++)
{
row_pointers8[z] = row_pointers8[0] + dim_y * z;
row_pointers8[z][0] = row_pointers8[0][0] + dim_y * dim_x * image_components * z;
row_pointers8[z][0] = row_pointers8[0][0] + dim_x * dim_y * image_components * z;
}

for (unsigned int z = 0; z < dim_z; z++)
Expand Down Expand Up @@ -1615,7 +1615,7 @@ static bool store_ktx_uncompressed_image(
for (unsigned int z = 1; z < dim_z; z++)
{
row_pointers16[z] = row_pointers16[0] + dim_y * z;
row_pointers16[z][0] = row_pointers16[0][0] + dim_y * dim_x * image_components * z;
row_pointers16[z][0] = row_pointers16[0][0] + dim_x * dim_y * image_components * z;
}

for (unsigned int z = 0; z < dim_z; z++)
Expand Down Expand Up @@ -2229,7 +2229,7 @@ static bool store_dds_uncompressed_image(
for (unsigned int z = 1; z < dim_z; z++)
{
row_pointers8[z] = row_pointers8[0] + dim_y * z;
row_pointers8[z][0] = row_pointers8[0][0] + dim_y * dim_z * image_components * z;
row_pointers8[z][0] = row_pointers8[0][0] + dim_x * dim_y * image_components * z;
}

for (unsigned int z = 0; z < dim_z; z++)
Expand Down Expand Up @@ -2295,7 +2295,7 @@ static bool store_dds_uncompressed_image(
for (unsigned int z = 1; z < dim_z; z++)
{
row_pointers16[z] = row_pointers16[0] + dim_y * z;
row_pointers16[z][0] = row_pointers16[0][0] + dim_y * dim_x * image_components * z;
row_pointers16[z][0] = row_pointers16[0][0] + dim_x * dim_y * image_components * z;
}

for (unsigned int z = 0; z < dim_z; z++)
Expand Down
Loading