Skip to content

Fix: Replace hardcoded external Vercel URL in Sidebar with internal route #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
APPLEPIE6969 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Replace hardcoded external Vercel URL in Sidebar with internal route #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,4 @@ yarn-error.log*
# typescript
*.tsbuildinfo
next-env.d.ts
venv/
2 changes: 1 addition & 1 deletion components/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { useTheme } from "@/components/ThemeProvider"
const sidebarItems = [
{ name: "nav.dashboard", href: "/dashboard", icon: "dashboard" },
{ name: "nav.courses", href: "/courses", icon: "menu_book" },
{ name: "nav.quizzes", href: "https://tiktok-kappa-steel.vercel.app/quizzes", icon: "quiz" },
{ name: "nav.quizzes", href: "/quizzes", icon: "quiz" },
{ name: "nav.study_sets", href: "/study-sets", icon: "library_books" },
{ name: "nav.tutor", href: "/study/explanation", icon: "psychology" },
{ name: "nav.resources", href: "/resources", icon: "folder_open" },
Expand Down
Binary file added verification/dev_server.log
View file
Open in desktop
Binary file not shown.
Binary file added verification/sidebar.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
28 changes: 28 additions & 0 deletions verification/verify_sidebar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
from playwright.sync_api import Page, expect, sync_playwright

def test_sidebar_quizzes_link(page: Page):
page.goto("http://localhost:3000/test-sidebar")
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Search for test-sidebar route definition or page
fd -t f -e tsx -e ts -e js . | xargs rg -l "test-sidebar" 2>/dev/null || echo "No test-sidebar references found"

# Check app router pages
fd -t f "page.tsx" --full-path "app" 2>/dev/null | head -20

# Search for any sidebar test pages
rg -l "test.*sidebar|sidebar.*test" --type ts --type tsx 2>/dev/null || true

Repository: APPLEPIE6969/StudyFlow

Length of output: 552

🏁 Script executed:

cat -n verification/verify_sidebar.py

Repository: APPLEPIE6969/StudyFlow

Length of output: 1101

Update test to use an existing route with sidebar rendering.

The /test-sidebar route does not exist in the application. The test will fail when attempting to navigate to this non-existent endpoint. Use an existing route where the sidebar is rendered, such as /dashboard (which exists in the codebase), instead of /test-sidebar.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@verification/verify_sidebar.py` at line 4, The test navigates to a
non-existent route via the page.goto call in verify_sidebar.py; change the URL
passed to page.goto("http://localhost:3000/test-sidebar") to an existing route
that renders the sidebar (e.g., "http://localhost:3000/dashboard") so the test
loads a real page that contains the sidebar component and can proceed with
assertions.


# Wait for sidebar to load
page.wait_for_selector("aside")

# Find the Quizzes link in the sidebar
quizzes_link = page.locator("aside a[href='/quizzes']")

# Verify the href is correct
href = quizzes_link.get_attribute("href")
assert href == "/quizzes", f"Expected href '/quizzes', got '{href}'"

print("Link is correct!")

# Take a screenshot
page.screenshot(path="verification/sidebar.png")
Comment on lines +18 to +19
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Screenshot directory may not exist.

The screenshot path verification/sidebar.png assumes the verification/ directory exists when the script runs. If the script is executed from a different working directory, this could fail.

🛡️ Suggested defensive fix 
+import os
+
 from playwright.sync_api import Page, expect, sync_playwright
 
 def test_sidebar_quizzes_link(page: Page):

And before the screenshot:

     # Take a screenshot
+    os.makedirs("verification", exist_ok=True)
     page.screenshot(path="verification/sidebar.png")
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Take a screenshot
page.screenshot(path="verification/sidebar.png")
# Take a screenshot
os.makedirs("verification", exist_ok=True)
page.screenshot(path="verification/sidebar.png")
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@verification/verify_sidebar.py` around lines 18 - 19, Ensure the target
directory exists before calling page.screenshot; add a check/create step (e.g.,
Path("verification").mkdir(parents=True, exist_ok=True)) immediately before the
page.screenshot(path="verification/sidebar.png") call in
verification/verify_sidebar.py so the directory is created if missing and the
screenshot write cannot fail due to a missing folder.


if __name__ == "__main__":
with sync_playwright() as p:
browser = p.chromium.launch(headless=True)
page = browser.new_page()
try:
test_sidebar_quizzes_link(page)
finally:
browser.close()