TonemapCommand::Run: Use image consistently#3283
Open
wantehchang wants to merge 1 commit into
Open
Conversation
Once the local variable `image` is declared and initialized to decoder->image, use `image` intead of `decoder->image` consistently.
wantehchang
commented
Jun 27, 2026
| } | ||
|
|
||
| avifImage* image = decoder->image; | ||
| avifImage* const image = decoder->image; |
Member
Author
There was a problem hiding this comment.
Adding this const makes it easier to prove that image is equal to decoder->image after this point.
| avifDiagnostics diag; | ||
| result = avifImageApplyGainMap( | ||
| decoder->image, image->gainMap, arg_headroom_, cicp.color_primaries, | ||
| image, image->gainMap, arg_headroom_, cicp.color_primaries, |
Member
Author
There was a problem hiding this comment.
I noticed this issue while reviewing your PR #3281. Please feel free to incorporate these changes into your PR, and I can abandon this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once the local variable
imageis declared and initialized to decoder->image, useimageintead ofdecoder->imageconsistently.