Rename avifSequenceHeader::av1C to codecConfig#3026
Open
y-guyon wants to merge 1 commit intoAOMediaCodec:mainfrom
Open
Rename avifSequenceHeader::av1C to codecConfig#3026y-guyon wants to merge 1 commit intoAOMediaCodec:mainfrom
y-guyon wants to merge 1 commit intoAOMediaCodec:mainfrom
Conversation
So that it can also be used to store av2C.
wantehchang
reviewed
Feb 13, 2026
| avifMatrixCoefficients matrixCoefficients; | ||
| avifRange range; | ||
| avifCodecConfigurationBox av1C; // TODO(yguyon): Rename or add av2C | ||
| avifCodecConfigurationBox codecConfig; // "av1C" for AV1 ("av2C" for AV2 if AVIF_CODEC_AVM) |
Collaborator
There was a problem hiding this comment.
It is better to wait until AV2CodecConfigurationBox ('av2C') is defined, because we may want to have both an av1C field and an av2C field, or even different struct types for AV1 and AV2 sequence headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that it can also be used to store av2C.