gdk-pixbuf: new quality settings #1907
Merged
wantehchang merged 2 commits intoAOMediaCodec:mainfrom Jan 4, 2024
Merged
Conversation
wantehchang
approved these changes
Jan 3, 2024
Collaborator
wantehchang
left a comment
wantehchang
left a comment
There was a problem hiding this comment.
Daniel: LGTM. I have two suggestions (one optional).
Plug-ins from https://gitlab.gnome.org/GNOME/gdk-pixbuf/ use similar coding style.
Now we set the quality parameter directly instead of the old way, when min_quantizer/maxQuantizer were used. YUV444 is used for highest quality range from 90 till 100.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wantehchang I wanted to clean the obsolete code and to unify the code style (so it is similar to the style like other plugins' authors use).
and I wanted to do this before start deeply focusing on animation (which is the work started by @Hiers in #1325 )