Updated primordial chem network#1966
Updated primordial chem network#1966psharda wants to merge 3 commits intoAMReX-Astro:developmentfrom
Conversation
|
Is this all SymPy-generated changes? Since the tests pass I will not perform a line-by-line review if that's the case. |
BenWibking
left a comment
BenWibking
left a comment
There was a problem hiding this comment.
If it's all symbolic regenerated stuff, I won't perform a line-by-line review.
I think it would be good to adopt the standard practice of including what version (including git commit) you used to symbolically generate this for future reference.
| //Last updated July 2024 | ||
| //Update notes: 1. the original version of this file used std::pow, which we replaced with a combo of std::exp/std::log wherever possible. | ||
| //Update notes: 2. added free-free cooling which was missing from the previous version | ||
| //Last updated March 2026 | ||
| //Author: Piyush Sharda (sharda@strw.leidenuniv.nl) |
There was a problem hiding this comment.
Could you add what version of your code you used to generate this? I think this will help in the future if it has to be regenerated.
|
This doesn't have to go in this PR, but we should discuss in the near future if we can find a way to avoid calling One option is to precalculate most of the rates and tabulate them, along the lines of JAFF's |
2 participants
This PR updates the primordial chemistry network to incorporate a couple of additional He reactions that are important at high temperatures, and use the same combination of H2 dissociation rates as Hunter et al. 2023.