Add the hybrid Powell solver option for true-SDC#3310
Open
zingale wants to merge 24 commits intoAMReX-Astro:developmentfrom
Open
Add the hybrid Powell solver option for true-SDC#3310zingale wants to merge 24 commits intoAMReX-Astro:developmentfrom
zingale wants to merge 24 commits intoAMReX-Astro:developmentfrom
Conversation
we were not using the correct number of source ghost cells when the shock variable was defined also lots of clang-tidy fixes
Member
Author
|
depends on AMReX-Astro/Microphysics#1958 |
Member
Author
|
This needs the Microphysics PR to be merged first. Otherwise, this seems to work well now. |
now I do, but it crashes
zingale
changed the title
Member
Author
|
this is ready for review. |
Member
Author
|
SDC regression tests pass: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate