Skip to content

Demote mtime error to warning#3164

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:fix_mtime
Mar 26, 2026
Merged

Demote mtime error to warning#3164
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:fix_mtime

Conversation

@dweindl
Copy link
Copy Markdown
Member

@dweindl dweindl commented Mar 23, 2026

Users reported problems with this check on some systems.

Closes #3163.

Users reported problems with this check on some systems.

Closes AMICI-dev#3163.
@dweindl dweindl self-assigned this Mar 23, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.72%. Comparing base (95ed9d2) to head (0d2f8ad).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3164      +/-   ##
==========================================
- Coverage   77.39%   76.72%   -0.67%     
==========================================
  Files         317      317              
  Lines       20631    20631              
  Branches     1483     1483              
==========================================
- Hits        15967    15829     -138     
- Misses       4656     4794     +138     
  Partials        8        8              
Flag Coverage Δ
cpp 70.45% <ø> (-0.03%) ⬇️
cpp_python 37.15% <ø> (ø)
petab 47.17% <ø> (ø)
python 68.91% <ø> (-0.03%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review March 23, 2026 13:27
@dweindl dweindl requested a review from a team as a code owner March 23, 2026 13:27
@dweindl dweindl added this pull request to the merge queue Mar 25, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 25, 2026
@dweindl dweindl merged commit 9fc9a41 into AMICI-dev:main Mar 26, 2026
44 of 53 checks passed
@dweindl dweindl deleted the fix_mtime branch March 26, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to disable model module import mtime check

2 participants