Skip to content

Fix CI: install dependencies via Poetry instead of bare pip #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix CI: install dependencies via Poetry instead of bare pip #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7efcee2
Initial plan
Copilot Mar 2, 2026
a8fb66c
Fix CI workflow to install dependencies using Poetry
Copilot Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,16 @@ jobs:
uses: actions/setup-python@v3
with:
python-version: ${{ matrix.python-version }}
- name: Install Poetry
run: pip install poetry
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI installs Poetry with an unpinned pip install poetry. This makes the workflow non-reproducible and can break the matrix unexpectedly when Poetry releases a version incompatible with one of the Python versions. Elsewhere in this repo CI pins Poetry (e.g., .github/workflows/run_ci.yml installs poetry==2.1.2) and upgrades pip first; consider doing the same here and using python -m pip ... to ensure Poetry is installed into the matrix Python environment.

Suggested change
run: pip install poetry
run: |
python -m pip install --upgrade pip
python -m pip install "poetry==2.1.2"

Copilot uses AI. Check for mistakes.
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install flake8 pytest
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
run: poetry install --with dev
- name: Lint with flake8
run: |
# stop the build if there are Python syntax errors or undefined names
flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
poetry run flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
poetry run flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
- name: Test with pytest
run: |
pytest
poetry run pytest
Loading