Skip to content

Refactor ask_user interactions#83

Open
F16shen wants to merge 1 commit intoAI-Shell-Team:mainfrom
F16shen:refactor/ask_user
Open

Refactor ask_user interactions#83
F16shen wants to merge 1 commit intoAI-Shell-Team:mainfrom
F16shen:refactor/ask_user

Conversation

@F16shen
Copy link
Collaborator

@F16shen F16shen commented Mar 26, 2026

Summary

  • migrate ask_user onto a structured interaction request/response model
  • support single_select, text_input, and choice_or_text through the same interaction pipeline
  • remove the obsolete inline ask_user path and update docs/tests for the new schema

Testing

  • pytest tests/test_shell.py tests/test_shell_prompt_io.py tests/test_interaction_ask_user.py tests/test_ask_user_tool.py -q

Follow-up

  • text_input default handling should be fixed in a follow-up PR
  • InteractionService TTY gating should be revisited to avoid short-circuiting shell fallback behavior

@github-actions
Copy link
Contributor

Thanks for the pull request. A maintainer will review it when available.

Please keep the PR focused, explain the why in the description, and make sure local checks pass before requesting review.

Contribution guide: https://github.com/AI-Shell-Team/aish/blob/main/CONTRIBUTING.md

@github-actions
Copy link
Contributor

This pull request description looks incomplete. Please update the missing sections below before review.

Missing items:

  • User-visible Changes
  • Compatibility
  • Change Type
  • Scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant