Skip to content

Refactor skill reminder hot reload context handling#82

Merged
F16shen merged 1 commit intoAI-Shell-Team:mainfrom
F16shen:fix/skill-reminder-runtime-context
Mar 26, 2026
Merged

Refactor skill reminder hot reload context handling#82
F16shen merged 1 commit intoAI-Shell-Team:mainfrom
F16shen:fix/skill-reminder-runtime-context

Conversation

@F16shen
Copy link
Collaborator

@F16shen F16shen commented Mar 26, 2026

Summary

  • move the skill reminder out of persisted conversation history and inject it as runtime context when assembling each request
  • reload the skill snapshot at safe points so the current reminder stays aligned with hot reloaded skills
  • include the current skill count in the reminder and update regression coverage for hot reload behavior

Testing

  • /home/lixin/workspace/aish/.venv/bin/python -m pytest tests/test_skill_hot_reload.py tests/test_context_manager.py tests/test_ask_user_tool.py tests/test_provider_registry.py

Move the skill reminder out of persisted conversation history and inject it as runtime context when assembling each model request. This keeps the reminder aligned with the latest skill snapshot instead of accumulating stale reminders across a session.

Also update the skill reminder text to include the current skill count, refresh the oracle prompt to treat the current reminder as the source of truth for the active turn, and add regression coverage for runtime reminder injection and skill tool validation across hot reload changes.
@github-actions
Copy link
Contributor

Thanks for the pull request. A maintainer will review it when available.

Please keep the PR focused, explain the why in the description, and make sure local checks pass before requesting review.

Contribution guide: https://github.com/AI-Shell-Team/aish/blob/main/CONTRIBUTING.md

@github-actions
Copy link
Contributor

This pull request description looks incomplete. Please update the missing sections below before review.

Missing items:

  • User-visible Changes
  • Compatibility
  • Change Type
  • Scope

@F16shen F16shen merged commit b985117 into AI-Shell-Team:main Mar 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants