Skip to content

fix: include custom outputs in xlsx finalisation#383

Open
yell0w12 wants to merge 1 commit into
AI-SDC:mainfrom
yell0w12:fix-xlsx-custom-outputs
Open

fix: include custom outputs in xlsx finalisation#383
yell0w12 wants to merge 1 commit into
AI-SDC:mainfrom
yell0w12:fix-xlsx-custom-outputs

Conversation

@yell0w12
Copy link
Copy Markdown

Fixes #312.

This PR updates XLSX finalisation so custom outputs are copied into the output folder and listed in the generated description sheet, matching the behavior of JSON finalisation.

QA:

  • Reproduced the bug locally before the fix: JSON copied the custom output, while XLSX created results.xlsx but did not copy or list the custom output.
  • Confirmed the same reproduction case passes after the fix.
  • Added regression coverage to test_finalise_excel.
  • Ran pytest: 128 passed.
  • Ran prek run -a: all checks passed.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.70%. Comparing base (aa8cb42) to head (ad0b970).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #383   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files           9        9           
  Lines        1354     1354           
=======================================
  Hits         1350     1350           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JessUWE
Copy link
Copy Markdown
Contributor

JessUWE commented May 18, 2026

Hello @yell0w12

thanks for doing this - much appreciated.

Please would you:

  • add your name to the citation file as described in here:

https://github.com/AI-SDC/ACRO/blob/main/CONTRIBUTING.md
https://github.com/AI-SDC/ACRO/blob/main/CITATION.cff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Custom outputs don't get included in the output folder when using xlsx option

2 participants