Skip to content

Avoid recreating existing metric descriptors in MetricsCollector #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 24, 2026
Merged

Avoid recreating existing metric descriptors in MetricsCollector #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pathwaysutils/experimental/shared_pathways_service/metrics_collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,15 @@ def _create_metric_descriptor(
"""Creates a metric descriptor if not already present."""
metric_type = METRIC_PREFIX + name
display_name = display_name or name
descriptor_name = (
f"projects/{self.project_id}/metricDescriptors/{metric_type}"
)
try:
self.client.get_metric_descriptor(name=descriptor_name)
_logger.debug("Metric descriptor %s already exists.", metric_type)
return
except exceptions.NotFound:
pass

try:
self.client.create_metric_descriptor(
Expand Down
Loading