Skip to content

feat: Support pre-training and post-training callbacks in promote_docker_image workflow - #4576

Open
RexBearIU wants to merge 1 commit into
mainfrom
user/jackyf/promote-docker-image-callbacks
Open

feat: Support pre-training and post-training callbacks in promote_docker_image workflow#4576
RexBearIU wants to merge 1 commit into
mainfrom
user/jackyf/promote-docker-image-callbacks

Conversation

@RexBearIU

Copy link
Copy Markdown
Collaborator

Description

Update .github/workflows/promote_docker_image.yml to handle both pre-training and post-training GitHub repository dispatch callbacks (airflow-dag-complete) independently.

  • Log TEST_TYPE (pre_training / post_training) from github.event.client_payload in the handle_result step.
  • Update the tag_docker_image matrix strategy to match test_type to its corresponding target Docker image:
    • pre_training: promotes maxtext_jax_nightly and maxtext_gpu_jax_nightly.
    • post_training: promotes maxtext_post_training_nightly.
  • Added a check (github.event.client_payload.test_type == '' || github.event.client_payload.test_type == matrix.test_type) so that each callback promotes only its relevant Docker images, while preserving full backward compatibility if test_type is omitted.

Tests

  • Validated YAML syntax with yamllint .github/workflows/promote_docker_image.yml.
  • Verified condition logic for test_type matrix evaluation (pre_training -> maxtext_jax_nightly, maxtext_gpu_jax_nightly; post_training -> maxtext_post_training_nightly; empty -> all images).

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@RexBearIU
RexBearIU force-pushed the user/jackyf/promote-docker-image-callbacks branch 2 times, most recently from 18a0364 to cecad28 Compare July 23, 2026 09:53
Comment thread .github/workflows/promote_docker_image.yml Outdated
@RexBearIU
RexBearIU force-pushed the user/jackyf/promote-docker-image-callbacks branch 2 times, most recently from cd5c30d to 43cbe5f Compare July 27, 2026 09:20
@RexBearIU
RexBearIU force-pushed the user/jackyf/promote-docker-image-callbacks branch from 43cbe5f to b722e20 Compare July 28, 2026 02:03
@RexBearIU
RexBearIU force-pushed the user/jackyf/promote-docker-image-callbacks branch from b722e20 to 1d381f6 Compare July 28, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants