Skip to content

Add grpc authentication to maxengine_server#3897

Open
bvandermoon wants to merge 1 commit into
mainfrom
bvandermoon-add-grpc-tls-config
Open

Add grpc authentication to maxengine_server#3897
bvandermoon wants to merge 1 commit into
mainfrom
bvandermoon-add-grpc-tls-config

Conversation

@bvandermoon
Copy link
Copy Markdown
Collaborator

@bvandermoon bvandermoon commented May 13, 2026

Description

Adds grpc_tls_certificate_path and grpc_tls_private_key_path configuration options to InferenceServer and updates maxengine_server.py to support secure gRPC TLS connections when configured.

  • Enables users to configure gRPC server credentials with TLS certificates and private keys for secure serving environments.
  • Defaults to insecure credentials when TLS paths are not provided, preserving seamless local unit testing and development workflows.

FIXES: b/510375382

Tests

Ran configuration unit tests on TPU VM:

pytest tests/unit/configs_test.py tests/unit/configs_value_test.py

All tests passed successfully.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@bvandermoon bvandermoon force-pushed the bvandermoon-add-grpc-tls-config branch from d8c3746 to ec80405 Compare May 13, 2026 21:19
@bvandermoon bvandermoon force-pushed the bvandermoon-add-grpc-tls-config branch from ec80405 to 7eecc6c Compare May 14, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants