Add 2d fsdp custom mesh and deprecate previous usages#3894
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
aaf6770 to
a80c31f
Compare
8569784 to
f28f38c
Compare
jesselu-google
approved these changes
May 13, 2026
RissyRan
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces 2d fsdp custom mesh and rule. Unlike
deepseek3-671b-2dfsdp, the new rule does not usefsdp_transposeandexpertas TP in attention part.This PR deprecates config yml
deepseek3-671b-2dfsdp.ymland flaguse_2dfsdp_sharding. In future, usecustom_mesh_and_rule=2d-fsdpfor the same functionality. Sharding dump tests are added for protection.Tests
Comparing before and after change, the sharding debugging info are almost the same, and real performance gets improved by the new mesh and rule. HBM usage gets slightly increased mainly because attention weights are replicated along fsdp_transpose.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.