Skip to content

simplify reward structure; add reward_exact_answer #3492

Merged
copybara-service[bot] merged 1 commit intomainfrom
atwigg/simplify_math_reward
Mar 24, 2026
Merged

simplify reward structure; add reward_exact_answer #3492
copybara-service[bot] merged 1 commit intomainfrom
atwigg/simplify_math_reward

Conversation

@andytwigg
Copy link
Collaborator

Description

simplify reward structure
comment out check_answer due to overlap with check_numbers
add reward_exact_answer

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/trainers/post_train/rl/train_rl.py 16.66% 5 Missing ⚠️
src/maxtext/trainers/post_train/rl/utils_rl.py 25.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@andytwigg andytwigg force-pushed the atwigg/simplify_math_reward branch from 86f4dfb to ee59b2f Compare March 24, 2026 21:05
Copy link
Collaborator

@richjames0 richjames0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@copybara-service copybara-service bot merged commit 16b6848 into main Mar 24, 2026
42 of 43 checks passed
@copybara-service copybara-service bot deleted the atwigg/simplify_math_reward branch March 24, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants