Configure pre-commit for license headers and automatic pyink reformat#3479
Draft
igorts-git wants to merge 1 commit intomainfrom
Draft
Configure pre-commit for license headers and automatic pyink reformat#3479igorts-git wants to merge 1 commit intomainfrom
igorts-git wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a third-party pre-commit hook to automatically add license headers if it is not present already.
Also allow pyink to automatically format files rather than just check them.
In both cases the newly modified files need to be
git add'ed again to be commited.Reminder: To benefit from this one needs to run
pre-commit installonce in their git repo.Tests
Manually modified existing files to remove the license and to break code formatting.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.