Skip to content

Split logical names in moe module#3473

Draft
NuojCheng wants to merge 1 commit intomainfrom
chengnuojin-separate-moe
Draft

Split logical names in moe module#3473
NuojCheng wants to merge 1 commit intomainfrom
chengnuojin-separate-moe

Conversation

@NuojCheng
Copy link
Collaborator

@NuojCheng NuojCheng commented Mar 20, 2026

Description

Split following logical names:

  • embed_no_exp into: embed_no_exp, embed_moe
  • activation_embed into: activation_embed, activation_embed_moe
  • activation_length_no_exp into: activation_length_no_exp, activation_length_no_exp_moe
  • activation_batch into activation, activation_batch
  • activation_batch into activation_batch, activation_batch_moe
  • activation_batch_no_exp into activation_batch_no_exp, activation_batch_no_exp_moe

Tests

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@NuojCheng NuojCheng force-pushed the chengnuojin-separate-moe branch from 7331bbf to e047c31 Compare March 20, 2026 19:44
@NuojCheng NuojCheng force-pushed the chengnuojin-separate-moe branch from e047c31 to 1259ecc Compare March 20, 2026 20:15
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/layers/moe.py 65.21% 8 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant